netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: David Miller <davem@davemloft.net>
Cc: Stephen Hemminger <shemminger@osdl.org>,
	Dale Farnsworth <dale@farnsworth.org>,
	netdev@vger.kernel.org
Subject: [NET] Update documentation of skb_linearize
Date: Fri, 10 Nov 2006 23:03:55 +0100	[thread overview]
Message-ID: <20061110220355.GC9453@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20061110133555.7400e555@freekitty>

The data is not released.

drivers/net/mv643xx_eth.c apart, each current caller issues
kfree_skb() when required.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 85577a4..380e344 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1235,7 +1235,7 @@ static inline int __skb_linearize(struct
  *	@skb: buffer to linarize
  *
  *	If there is no free memory -ENOMEM is returned, otherwise zero
- *	is returned and the old skb data released.
+ *	is returned.
  */
 static inline int skb_linearize(struct sk_buff *skb)
 {
@@ -1247,7 +1247,7 @@ static inline int skb_linearize(struct s
  *	@skb: buffer to process
  *
  *	If there is no free memory -ENOMEM is returned, otherwise zero
- *	is returned and the old skb data released.
+ *	is returned.
  */
 static inline int skb_linearize_cow(struct sk_buff *skb)
 {

  reply	other threads:[~2006-11-10 22:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061110191745.GA13783@codepoet.org>
2006-11-10 19:54 ` [RFT] mv643xxx_eth_start_xmit oops Stephen Hemminger
2006-11-10 20:30   ` Francois Romieu
2006-11-10 20:53     ` Dale Farnsworth
2006-11-10 21:03       ` Francois Romieu
2006-11-10 21:07         ` Stephen Hemminger
2006-11-10 21:30           ` Francois Romieu
2006-11-10 21:35             ` Stephen Hemminger
2006-11-10 22:03               ` Francois Romieu [this message]
2006-11-10 22:53                 ` [NET] Update documentation of skb_linearize David Miller
2006-11-10 23:34                   ` Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061110220355.GC9453@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=dale@farnsworth.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).