From: David Miller <davem@davemloft.net>
To: gerrit@erg.abdn.ac.uk
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux
Date: Sun, 12 Nov 2006 23:46:15 -0800 (PST) [thread overview]
Message-ID: <20061112.234615.95058980.davem@davemloft.net> (raw)
In-Reply-To: <200611130734.49700@strip-the-willow>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Mon, 13 Nov 2006 07:34:48 +0000
> Quoting David Miller:
> |
> | I can't apply any of this Gerrit.
> |
> | What makes net/ipv4/udplite.c get built at all? I see no
> | changes to net/ipv4/Makefile, so you must have stuffed up
> | the generation of your patches.
> This is a misunderstanding: udplite.o will never be built,
> it is #included in udp.c. Witness
>
> ==> net/ipv4/udp.c, line 1727:
>
> /* the extensions for UDP-Lite (RFC 3828) */
> #include "udplite.c"
>
> ==> net/ipv6/udp.c, line 1009:
> /* the extensions for UDP-Lite (RFC 3828) */
> #include "udplite.c"
Sorry I misread this.
I'm not a huge fan of source file inclusion like this.
It's not a header file, it contains code.
Is there a way to build this as a seperate object somehow?
next prev parent reply other threads:[~2006-11-13 7:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 16:09 [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux Gerrit Renker
2006-11-10 17:37 ` Stephen Hemminger
2006-11-10 22:38 ` David Miller
2006-11-10 22:48 ` Stephen Hemminger
2006-11-13 7:43 ` Gerrit Renker
2006-11-13 7:56 ` Gerrit Renker
2006-11-10 22:38 ` David Miller
2006-11-13 7:34 ` Gerrit Renker
2006-11-13 7:46 ` David Miller [this message]
[not found] ` <200611130809.34613@strip-the-willow>
[not found] ` <20061113.001615.74565996.davem@davemloft.net>
2006-11-13 8:32 ` Gerrit Renker
2006-11-13 9:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061112.234615.95058980.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).