From: David Kimdon <david.kimdon@devicescape.com>
To: netdev@vger.kernel.org
Cc: "John W. Linville" <linville@tuxdriver.com>, Jiri Benc <jbenc@suse.cz>
Subject: [take4 0/5] d80211: remove bitfields from include/net/d80211.h
Date: Sun, 12 Nov 2006 09:52:34 -0800 [thread overview]
Message-ID: <20061112175234.GA11728@devicescape.com> (raw)
Continue d80211 bitfield removal. In general, compilers have
difficulty generating efficient code for bitfields. This patchset
removes all bitfields from include/net/d80211.h.
I converted the 1 bit bitfields into a bit in a u32 flags structure
member. Larger bitfields I converted into their u8/u16/whatever
equivalent.
This should be a no-op from a functionality standpoint.
Changes from take3:
Switch flags structure member to u32 for struct ieee80211_tx_control
and struct ieee80211_key_conf.
Refresh to apply to current wireless-dev
- update p54 driver to new API
- update patch based on various changes in bcm43xx and rt2x00 drivers
- account for removal of extra_hdr_room bitfield
Changes from take2:
Refresh to apply to current wireless-dev.
Changes from take1:
Update rt2500usb.c and rt73usb.c drivers based on the new structures.
Changes from take0:
Update the patches to apply on top of the following patches:
d80211: remove unused Super AG definitions, purge comment
(http://marc.theaimsgroup.com/?l=linux-netdev&m=116102409931269&w=2)
d80211: remove initialization of unused xr structure members
(http://marc.theaimsgroup.com/?l=linux-netdev&m=116076811809305&w=4)
d80211: remove unused xr structure members, interface, etc.
(http://marc.theaimsgroup.com/?l=linux-netdev&m=115989929600617&w=4)
For key_conf_bitfields.patch change the new flags member to u8 from u32.
For tx_control_bitfields.patch move the rts_cts_duration and retry_limit members
in ieee80211_tx_control to allow for smaller structure size and change the
flags member from u32 to u16.
For tx_status_bitfields.patch, in
drivers/net/wireless/d80211/bcm43xx/bcm43xx_dma.c and
drivers/net/wireless/d80211/bcm43xx/bcm43xx_pio.c note that
ieee80211_tx_status is already zero'd, so the ack bit only needs to be
set, not cleared.
--
reply other threads:[~2006-11-12 17:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061112175234.GA11728@devicescape.com \
--to=david.kimdon@devicescape.com \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).