Re: [patch sungem] improved locking

[David Miller <davem@davemloft.net>]

From: "Eric Lemoine" <eric.lemoine@gmail.com>
Date: Mon, 13 Nov 2006 00:11:49 +0100

> +#if GEM_INTERRUPT_LOCKLESS
> +
> +/* Bitmask representing the interrupt conditions that we clear using GREG_IACK.
> + * We clear all the top-level interrupt conditions (bits 0 through 6) that we
> + * handle.
> + */
> +#define GREG_STAT_IACK		(GREG_STAT_NAPI & 0x3f)
> +#endif

I'm asking for this a second time...  and to be honest I'm a little
bit ticked off.

Please spell out the explicit bits using the existing defines to
create this mask.  Do not use this magic 0x3f magic number which
contains bits which are undefined, so obtain this mask (as I asked the
first time) like this:

	(GREG_STAT_TXINTME | GREG_STAT_TXALL |
	 GREG_STAT_TXDONE | GREG_STAT_RXDONE |
	 GREG_STAT_RXNOBUF)

I will not go through the effort a third time, instead I will simply
ignore your patch submissions, it's that simple.  If you ignore me, I
ignore you.

You want me to review this patch and the locking bits, but you're
never going to get to that point if you continually ignore the
most simple requests I'm making of you. :-(