From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux
Date: Mon, 13 Nov 2006 07:34:48 +0000 [thread overview]
Message-ID: <200611130734.49700@strip-the-willow> (raw)
In-Reply-To: <20061110.143801.39158000.davem@davemloft.net>
Quoting David Miller:
|
| I can't apply any of this Gerrit.
|
| What makes net/ipv4/udplite.c get built at all? I see no
| changes to net/ipv4/Makefile, so you must have stuffed up
| the generation of your patches.
This is a misunderstanding: udplite.o will never be built,
it is #included in udp.c. Witness
==> net/ipv4/udp.c, line 1727:
/* the extensions for UDP-Lite (RFC 3828) */
#include "udplite.c"
==> net/ipv6/udp.c, line 1009:
/* the extensions for UDP-Lite (RFC 3828) */
#include "udplite.c"
| Please resubmit all 3 patches once you've corrected this
| and actually _tested_ the patch you submitted. You know,
I do not submit patches that I don't have tested myself. It
all works: no compile errors, all functions (UDPv4/v6 and
UDP-Litev4/v6) confirmed to work.
You can find test applications for UDP-Lite (IPPROTO=136) on
http://www.erg.abdn.ac.uk/users/gerrit/udp-lite/files/udplite_linux.tar.gz
(subdirectory apps/{sock,ttcp,vlc,client-server,perl_client-server}
Regards
Gerrit
next prev parent reply other threads:[~2006-11-13 7:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 16:09 [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux Gerrit Renker
2006-11-10 17:37 ` Stephen Hemminger
2006-11-10 22:38 ` David Miller
2006-11-10 22:48 ` Stephen Hemminger
2006-11-13 7:43 ` Gerrit Renker
2006-11-13 7:56 ` Gerrit Renker
2006-11-10 22:38 ` David Miller
2006-11-13 7:34 ` Gerrit Renker [this message]
2006-11-13 7:46 ` David Miller
[not found] ` <200611130809.34613@strip-the-willow>
[not found] ` <20061113.001615.74565996.davem@davemloft.net>
2006-11-13 8:32 ` Gerrit Renker
2006-11-13 9:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611130734.49700@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).