From: David Miller <davem@davemloft.net>
To: gerrit@erg.abdn.ac.uk
Cc: ak@suse.de, netdev@vger.kernel.org
Subject: Re: [PATCHv2 2/2]: net/ipv{4,6}: reduce code size by inlining
Date: Tue, 14 Nov 2006 20:20:21 -0800 (PST) [thread overview]
Message-ID: <20061114.202021.23014512.davem@davemloft.net> (raw)
In-Reply-To: <200611141250.33918@strip-the-willow>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Tue, 14 Nov 2006 12:50:33 +0000
> Quoting Andi Kleen:
> | On Tuesday 14 November 2006 09:49, Gerrit Renker wrote:
> | > [UDP]: Reduce size of shared code
> | >
> | > This patch reduces size of source code files by moving
> | > some of the smaller functions shared by UDP and UDP-Lite
> | > into the header file udp_impl.h, and in-lining these.
> | >
> | > It is an optimisation and applies on top of the previous
> | > UDP-Lite patch.
> |
> | Wouldn't it be better to just call them? They all don't
> | particularly time critical.
> This patch was sent as an optional add-on, it is not as important
> as the other one. You are probably right - I also noted that the
> gains (in terms of line numbers) are not as high as intended.
I'm not too sure on this one either, so I won't apply this one
for now.
prev parent reply other threads:[~2006-11-15 4:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-14 8:49 [PATCHv2 2/2]: net/ipv{4,6}: reduce code size by inlining Gerrit Renker
2006-11-14 12:27 ` Andi Kleen
2006-11-14 12:50 ` Gerrit Renker
2006-11-15 4:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061114.202021.23014512.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ak@suse.de \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).