From: David Miller <davem@davemloft.net>
To: jheffner@psc.edu
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] fix up sysctl_tcp_mem initialization
Date: Tue, 14 Nov 2006 20:31:18 -0800 (PST) [thread overview]
Message-ID: <20061114.203118.35665382.davem@davemloft.net> (raw)
In-Reply-To: <455A20BD.6010508@psc.edu>
From: John Heffner <jheffner@psc.edu>
Date: Tue, 14 Nov 2006 15:02:05 -0500
> The initial values of sysctl_tcp_mem are sometimes greater than the
> total memory in the system (particularly on SMP systems). This patch
> ensures that tcp_mem[2] is always <= 3/4 nr_kernel_pages.
This is a genuine bug fix so I'll apply this, thanks for taking
care of these corner-case bugs in TCP sizing Jeff.
> However, I wonder if we want to set this differently than the way this
> patch does it. Depending on how far off the memory size is from a power
> of two (exactly equal to a power of two is the worst case), and if total
> memory <128M, it can be substantially less than 3/4.
Longer term, yes, probably a better way exists.
So you concern is that when we round to a power of 2 like we do
now, we often mis-shoot?
next prev parent reply other threads:[~2006-11-15 4:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-14 20:02 [PATCH] fix up sysctl_tcp_mem initialization John Heffner
2006-11-15 4:31 ` David Miller [this message]
2006-11-15 17:46 ` John Heffner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061114.203118.35665382.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jheffner@psc.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).