From: Jouni Malinen <jkm@devicescape.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Hong Liu <hong.liu@intel.com>, Jiri Benc <jbenc@suse.cz>,
"John W. Linville" <linville@tuxdriver.com>,
netdev <netdev@vger.kernel.org>, Michael Buesch <mb@bu3sch.de>,
"James P. Ketrenos" <ipw2100-admin@linux.intel.com>,
Simon Barber <simon@devicescape.com>
Subject: Re: [patch 1/2]d80211: hardware TKIP support for ipw3945
Date: Thu, 16 Nov 2006 09:40:53 -0800 [thread overview]
Message-ID: <20061116174053.GA7531@instant802.com> (raw)
In-Reply-To: <1163698700.3392.7.camel@johannes.berg>
On Thu, Nov 16, 2006 at 06:38:20PM +0100, Johannes Berg wrote:
> Oh, good point. Will need to think about this more. But right now, if
> that MMIC flag is set (i.e. hw does MMIC), we still do MMIC for
> fragmented frames. And there's actually a bug here I think: if hw does
> MMIC, how can the driver tell not to do it on those frames it's getting
> as fragments?
It's been awhile since I working on this part, but if I remember
correctly, this can be done easily by the driver behaving different
based on the frame being fragmented or not (it is fragmented if MoreFrag
flag is set or seq# != 0). That's the way it was done with hardware
designs that allow full TKIP hwaccel for MSDUs that are not fragmented,
but require software implementation of Michael MIC if MSDU is
fragmented.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2006-11-16 17:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 9:19 [patch 1/2]d80211: hardware TKIP support for ipw3945 Hong Liu
2006-10-21 21:10 ` Matthieu CASTET
2006-10-23 12:40 ` Jiri Benc
2006-10-23 12:48 ` Johannes Berg
2006-10-23 12:56 ` Jiri Benc
2006-10-24 8:20 ` Hong Liu
2006-10-24 8:35 ` Johannes Berg
2006-10-24 8:38 ` Hong Liu
2006-10-24 9:10 ` Johannes Berg
2006-10-24 9:12 ` Johannes Berg
2006-10-25 8:28 ` Hong Liu
2006-10-25 8:50 ` Johannes Berg
2006-11-14 2:22 ` Hong Liu
2006-11-15 16:25 ` Johannes Berg
2006-11-16 9:52 ` Johannes Berg
2006-11-16 17:21 ` Jouni Malinen
2006-11-16 17:38 ` Johannes Berg
2006-11-16 17:40 ` Jouni Malinen [this message]
2006-11-16 17:49 ` Johannes Berg
2006-10-23 13:04 ` Stuffed Crust
2006-10-23 15:29 ` David Kimdon
2006-10-23 16:31 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061116174053.GA7531@instant802.com \
--to=jkm@devicescape.com \
--cc=hong.liu@intel.com \
--cc=ipw2100-admin@linux.intel.com \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=simon@devicescape.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).