* [PATCH] netdev: don't allow register_netdev with blank name
@ 2006-11-17 21:41 Stephen Hemminger
2006-11-20 23:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2006-11-17 21:41 UTC (permalink / raw)
To: Jeff Garzik, David S. Miller; +Cc: netdev
This bit of old backwards compatibility cruft can be removed in 2.6.20.
If there is still an device that calls register_netdev()
with a zero or blank name, it will get -EINVAL from register_netdevice().
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- linux-2.6.19-rc6.orig/net/core/dev.c 2006-11-17 13:35:04.000000000 -0800
+++ linux-2.6.19-rc6/net/core/dev.c 2006-11-17 13:37:46.000000000 -0800
@@ -3035,15 +3035,6 @@
goto out;
}
- /*
- * Back compatibility hook. Kill this one in 2.5
- */
- if (dev->name[0] == 0 || dev->name[0] == ' ') {
- err = dev_alloc_name(dev, "eth%d");
- if (err < 0)
- goto out;
- }
-
err = register_netdevice(dev);
out:
rtnl_unlock();
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] netdev: don't allow register_netdev with blank name
2006-11-17 21:41 [PATCH] netdev: don't allow register_netdev with blank name Stephen Hemminger
@ 2006-11-20 23:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-11-20 23:46 UTC (permalink / raw)
To: shemminger; +Cc: jgarzik, netdev
From: Stephen Hemminger <shemminger@osdl.org>
Date: Fri, 17 Nov 2006 13:41:58 -0800
> This bit of old backwards compatibility cruft can be removed in 2.6.20.
> If there is still an device that calls register_netdev()
> with a zero or blank name, it will get -EINVAL from register_netdevice().
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-20 23:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-17 21:41 [PATCH] netdev: don't allow register_netdev with blank name Stephen Hemminger
2006-11-20 23:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).