From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: David Miller <davem@davemloft.net>,
Masahide NAKAMURA <nakam@linux-ipv6.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2][XFRM]: Sub-policies beautification
Date: Fri, 17 Nov 2006 17:42:53 +0100 [thread overview]
Message-ID: <20061117164253.GE8693@postel.suug.ch> (raw)
In-Reply-To: <1163772616.5107.40.camel@jzny2>
* jamal <hadi@cyberus.ca> 2006-11-17 09:10
> First one
>
> cheers,
> jamal
> [XFRM]: Make copy_to_user_policy_type take a type
> Make copy_to_user_policy_type take a type instead a policy and
> fix its users to pass the type
>
> Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
>
> ---
> commit 5e6a47d1e7baabd38cca9d01f3d78ae1319db535
> tree cb4b19b38076cdf545a591ae9d5d6ecd8849c0bc
> parent c3d793454ab2a36c2d618d226d7de975ab9b7570
> author Jamal Hadi Salim <hadi@cyberus.ca> Fri, 17 Nov 2006 08:52:26 -0500
> committer Jamal Hadi Salim <hadi@jzny2.(none)> Fri, 17 Nov 2006 08:52:26 -0500
>
> net/xfrm/xfrm_user.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
> index c4cde57..3c34385 100644
> --- a/net/xfrm/xfrm_user.c
> +++ b/net/xfrm/xfrm_user.c
> @@ -1082,12 +1082,12 @@ static inline int copy_to_user_sec_ctx(s
> }
>
> #ifdef CONFIG_XFRM_SUB_POLICY
> -static int copy_to_user_policy_type(struct xfrm_policy *xp, struct sk_buff *skb)
> +static int copy_to_user_policy_type(__u8 type, struct sk_buff *skb)
Could you maybe use u8 instead of the userspace alternative __u8?
The other patches look good.
next prev parent reply other threads:[~2006-11-17 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 14:10 [PATCH 1/2][XFRM]: Sub-policies beautification jamal
2006-11-17 16:42 ` Thomas Graf [this message]
2006-11-17 16:49 ` jamal
2006-11-17 16:52 ` Thomas Graf
2006-11-21 0:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061117164253.GE8693@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=nakam@linux-ipv6.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).