[[PATCH][XFRM]: Sub-policies broke policy events

[[PATCH][XFRM]: Sub-policies broke policy events

[jamal]

[-- Attachment #1: Type: text/plain, Size: 133 bytes --]


Found the cause of my problems. 
Dave, this is against Linus tree because it is bug fix.

Nakamura-san please ACK.

cheers,
jamal



[-- Attachment #2: ipsec-subp --]
[-- Type: text/plain, Size: 1084 bytes --]

[XFRM]: Sub-policies broke policy events
XFRM policy events are broken when sub-policy feature is turned on.
A simple test to verify this:
run ip xfrm mon on one window and add then delete a policy on another
window ..

Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>

---
commit b53ec68c276ac1d879759de130620a72254cb969
tree b91ed5cf9090478bc49bd7414be6dd295352ff2b
parent 1b9bb3c14c60324b54645ffefbe6d270f9fd191c
author Jamal Hadi Salim <hadi@cyberus.ca> Fri, 17 Nov 2006 08:13:16 -0500
committer Jamal Hadi Salim <hadi@jzny2.(none)> Fri, 17 Nov 2006 08:13:16 -0500

 net/xfrm/xfrm_user.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index b43e764..2dae1c1 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -2060,6 +2060,9 @@ static int xfrm_notify_policy(struct xfr
 		len += RTA_SPACE(headlen);
 		headlen = sizeof(*id);
 	}
+#ifdef CONFIG_XFRM_SUB_POLICY
+	len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
+#endif
 	len += NLMSG_SPACE(headlen);
 
 	skb = alloc_skb(len, GFP_ATOMIC);

Re: [[PATCH][XFRM]: Sub-policies broke policy events

[Masahide NAKAMURA]

On Fri, 17 Nov 2006 08:34:44 -0500
jamal <hadi@cyberus.ca> wrote:

> 
> Found the cause of my problems. 
> Dave, this is against Linus tree because it is bug fix.
> 
> Nakamura-san please ACK.
> 
> cheers,
> jamal


It looks fine to me. Thanks, Jamal.

Acked-by: Masahide NAKAMURA <nakam@linux-ipv6.org>



> [XFRM]: Sub-policies broke policy events
> XFRM policy events are broken when sub-policy feature is turned on.
> A simple test to verify this:
> run ip xfrm mon on one window and add then delete a policy on another
> window ..
> 
> Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
> 
> ---
-- 
Masahide NAKAMURA

Re: [[PATCH][XFRM]: Sub-policies broke policy events

[David Miller]

From: Masahide NAKAMURA <nakam@linux-ipv6.org>
Date: Sat, 18 Nov 2006 17:51:59 +0900

> On Fri, 17 Nov 2006 08:34:44 -0500
> jamal <hadi@cyberus.ca> wrote:
> 
> > 
> > Found the cause of my problems. 
> > Dave, this is against Linus tree because it is bug fix.
> > 
> > Nakamura-san please ACK.
> > 
> > cheers,
> > jamal
> 
> 
> It looks fine to me. Thanks, Jamal.
> 
> Acked-by: Masahide NAKAMURA <nakam@linux-ipv6.org>

Applied, thanks everyone.