From: David Miller <davem@davemloft.net>
To: nakam@linux-ipv6.org
Cc: hadi@cyberus.ca, netdev@vger.kernel.org
Subject: Re: [PATCH][XFRM]: nlmsg length not computed correctly in the presence of subpolicies
Date: Sun, 19 Nov 2006 17:55:44 -0500 (EST) [thread overview]
Message-ID: <20061119.175544.59672238.davem@davemloft.net> (raw)
In-Reply-To: <20061118180712.A7A4.NAKAM@linux-ipv6.org>
From: Masahide NAKAMURA <nakam@linux-ipv6.org>
Date: Sat, 18 Nov 2006 18:08:42 +0900
> On Fri, 17 Nov 2006 08:48:31 -0500
> jamal <hadi@cyberus.ca> wrote:
>
> > Another one in the same spirit as before. Compiles. I dont have
> > a good test case, but looks right.
> > Nakamura-san please ACK and Dave (as before this goes in as a bug-fix).
>
> Acked-by: Masahide NAKAMURA <nakam@linux-ipv6.org>
>
> I've tested with your patch and the result is fine.
>
> However, unlike the add/delete XFRM policy case pointed by Jamal
> as the previous patch, I don't see the error without this patch on my
> environment about acqiure.
> (Maybe, does acquire path happen to make some buffer for policy type
> since the structures is not aligned cleanly?)
>
> ..Anyway, the fix is correct for me. David, please apply it, too.
Applied, thanks.
prev parent reply other threads:[~2006-11-19 22:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 13:48 [PATCH][XFRM]: nlmsg length not computed correctly in the presence of subpolicies jamal
2006-11-18 9:08 ` Masahide NAKAMURA
2006-11-19 22:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061119.175544.59672238.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=nakam@linux-ipv6.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).