netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jay Cliburn <jacliburn@bellsouth.net>
Cc: jeff@garzik.org, shemminger@osdl.org, romieu@fr.zoreil.com,
	csnook@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] atl1: Build files for Attansic L1 driver
Date: Sun, 19 Nov 2006 15:24:32 -0800	[thread overview]
Message-ID: <20061119152432.a85d4166.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20061119202915.GB29736@osprey.hogchain.net>

On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:

> From: Jay Cliburn <jacliburn@bellsouth.net>
> 
> This patch contains the build files for the Attansic L1 gigabit ethernet
> adapter driver.
> 
> Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
> ---
> 
>  Kconfig       |   12 ++++++++++++
>  Makefile      |    1 +
>  atl1/Makefile |   30 ++++++++++++++++++++++++++++++
>  3 files changed, 43 insertions(+)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 6e863aa..f503d10 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2329,6 +2329,18 @@ config QLA3XXX
>  	  To compile this driver as a module, choose M here: the module
>  	  will be called qla3xxx.
>  
> +config ATL1
> +	tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
> +	depends on NET_PCI && PCI && EXPERIMENTAL
> +	select CRC32
> +	select MII
> +	---help---
> +	  This driver supports Attansic L1 gigabit ethernet adapter.
> +
> +	  To compile this driver as a module, choose M here.  The module
> +	  will be called atl1.
> +
> +
>  endmenu

One problem here is that MII depends on NET_ETHERNET, which is
10/100 ethernet, which may not be enabled if someone has only
gigabit ethernet.  :)

I have a partial patch which moves MII and PHYLIB outside of
NET_ETHERNET.  That also makes them usable by USB or other
non-drivers/net/ drivers, e.g., again without the need
to enable NET_ETHERNET if someone only has USB ethernet.  :(

I'll try to post it for review later today.

---
~Randy

  reply	other threads:[~2006-11-19 23:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-19 20:29 [PATCH 1/4] atl1: Build files for Attansic L1 driver Jay Cliburn
2006-11-19 23:24 ` Randy Dunlap [this message]
2006-11-20  6:06   ` Chris Snook
2006-11-20 15:41     ` Randy Dunlap
2006-11-20 16:19       ` Chris Snook
2006-11-20 20:04         ` Francois Romieu
  -- strict thread matches above, loose matches on Subject: below --
2007-01-11  0:40 Jay Cliburn
2007-01-11  9:19 ` Christoph Hellwig
2007-01-11  9:31   ` Chris Snook
2007-01-11  9:49     ` Jeff Garzik
2007-01-21 21:05 Jay Cliburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061119152432.a85d4166.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=csnook@redhat.com \
    --cc=jacliburn@bellsouth.net \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).