netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Chris Snook <csnook@redhat.com>
Cc: Jay Cliburn <jacliburn@bellsouth.net>,
	jeff@garzik.org, shemminger@osdl.org, romieu@fr.zoreil.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] atl1: Revised Attansic L1 ethernet driver
Date: Mon, 20 Nov 2006 09:46:03 +0000	[thread overview]
Message-ID: <20061120094603.1d1e528a@localhost.localdomain> (raw)
In-Reply-To: <45614C80.5070303@redhat.com>

> > Be careful with :1 bitfields when working with hardware - the compiler
> > has more than one choice about how to pack them.
> 
> Lacking a spec, I'm not entirely sure what the original intent was, so 
> we're stuck with testing.  Is there a specific disambiguation technique 
> you recommend?

Assuming the driver works on x86 then you know how the bits are laid out.
You may find later you need to put in ifdefs for bitfield endian-ness as
we do in things like include/linux/ip.h


  reply	other threads:[~2006-11-20  9:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-19 20:28 [PATCH 0/4] atl1: Revised Attansic L1 ethernet driver Jay Cliburn
2006-11-20  1:15 ` Alan
2006-11-20  6:34   ` Chris Snook
2006-11-20  9:46     ` Alan [this message]
2006-11-20  6:37 ` Chris Snook
2006-11-21 20:25 ` Luca Tettamanti
2006-11-25 22:43   ` Luca Tettamanti
2006-11-26  1:33     ` Jay Cliburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061120094603.1d1e528a@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=csnook@redhat.com \
    --cc=jacliburn@bellsouth.net \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).