From: Stephen Hemminger <shemminger@osdl.org>
To: "Yang, Steve" <steve.yang@windriver.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [patch] Performance enhancement patches for SB1250 MAC
Date: Mon, 20 Nov 2006 15:35:48 -0800 [thread overview]
Message-ID: <20061120153548.71f90b7a@freekitty> (raw)
In-Reply-To: <F09F8223E8BE7D42BDA1800B19F3440D922017@ALA-MAIL03.corp.ad.wrs.com>
On Mon, 20 Nov 2006 13:40:01 -0800
"Yang, Steve" <steve.yang@windriver.com> wrote:
> Stephen,
>
> Sorry for responding late.
>
> 1. I've submitted two patches, one for NAPI and the other for SKB_Cache.
> They can go in individually. You've expressed objections to SKB_Cache.
> What about the one for NAPI?
Yes, the NAPI one is great.
>
> 2. As for SKB_Cache patch, your concern about "maintenance" is valid.
> However, the cost for allocating skb is not trivial for performance,
> hence the patch. This is backed up by performance data measured. 20%
> difference is a conservative number here.
>
I am not the final decider on this. Ask Jeff/David? Maybe there is some
more general work that can be done to speed up skb allocation.
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-11-20 23:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 21:40 [patch] Performance enhancement patches for SB1250 MAC Yang, Steve
2006-11-20 23:35 ` Stephen Hemminger [this message]
2006-11-20 23:58 ` David Miller
2006-11-21 14:26 ` Martin Michlmayr
-- strict thread matches above, loose matches on Subject: below --
2006-11-22 0:33 Yang, Steve
2006-11-21 16:45 Yang, Steve
2006-11-21 19:12 ` Stephen Hemminger
[not found] <D9055C0A0A86BD4E89AD96A89EA767DBA6AFBC@ALA-MAIL03.corp.ad.wrs.com>
2006-10-13 20:24 ` Stephen Hemminger
2006-10-12 21:54 Yang, Steve
2006-10-12 22:13 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061120153548.71f90b7a@freekitty \
--to=shemminger@osdl.org \
--cc=netdev@vger.kernel.org \
--cc=steve.yang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox