Re: [PATCH] d80211: remove useless driver name field

[Christoph Hellwig <hch@infradead.org>]

On Mon, Nov 20, 2006 at 07:40:00PM +0100, Johannes Berg wrote:
> On Mon, 2006-11-20 at 10:32 -0800, Jouni Malinen wrote:
> > On Fri, Nov 17, 2006 at 11:50:35PM +0100, Johannes Berg wrote:
> > 
> > > struct ieee80211_ops has a driver name field that's never used.
> > > Remove it.
> > 
> > >  struct ieee80211_ops {
> > > -	/* Driver name */
> > > -	char *name;
> > > -
> > 
> > Is this the same name field that was in struct ieee80211_hw?
> 
> Yes, it moved here during the shuffle in patch 6.
> 
> > It was used
> > and the main reason was to allow rate control algorithms to be
> > implemented in a way which allows hardware specific features (e.g.,
> > different TX/RX status data) to be used to optimize rate selection. I
> > would not remove this field unless there is another way of allowing
> > something like this to be done in the rate control modules.
> 
> Oh, I hadn't found any references to it but I guess those rate control
> modules are internal. I'm fine with leaving it in.

NACK.  We don't leave unused junk in tree.  Especially not to allow
implementing layering violations in non-public code.