From: David Miller <davem@davemloft.net>
To: kernel@irasnyder.com
Cc: netdev@vger.kernel.org, mchan@broadcom.com
Subject: Re: [PATCH] tg3: add missing unlock in tg3_open() error path
Date: Tue, 21 Nov 2006 17:44:49 -0800 (PST) [thread overview]
Message-ID: <20061121.174449.88702984.davem@davemloft.net> (raw)
In-Reply-To: <20061121142311.4d1b9510.kernel@irasnyder.com>
From: Ira Snyder <kernel@irasnyder.com>
Date: Tue, 21 Nov 2006 14:23:11 -0800
> [PATCH] tg3: add missing unlock in tg3_open() error path
>
> Sparse noticed a locking imbalance in tg3_open(). This patch adds an unlock
> to one of the error paths, so that tg3_open() always exits without the
> lock held.
>
> Signed-off-by: Ira W. Snyder <kernel@irasnyder.com>
Nice catch. Patch applied, thanks a lot.
prev parent reply other threads:[~2006-11-22 1:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 22:23 [PATCH] tg3: add missing unlock in tg3_open() error path Ira Snyder
2006-11-22 1:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061121.174449.88702984.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel@irasnyder.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).