From: David Miller <davem@davemloft.net>
To: okir@suse.de
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make udp_encap_rcv use pskb_may_pull
Date: Wed, 22 Nov 2006 20:11:36 -0800 (PST) [thread overview]
Message-ID: <20061122.201136.129449260.davem@davemloft.net> (raw)
In-Reply-To: <20061123000144.GB7452@suse.de>
From: Olaf Kirch <okir@suse.de>
Date: Thu, 23 Nov 2006 01:01:44 +0100
>
> Make udp_encap_rcv use pskb_may_pull
>
> IPsec with NAT-T breaks on some notebooks using the latest e1000 chipset,
> when header split is enabled. When receiving sufficiently large packets, the
> driver puts everything up to and including the UDP header into the header
> portion of the skb, and the rest goes into the paged part. udp_encap_rcv
> forgets to use pskb_may_pull, and fails to decapsulate it. Instead, it
> passes it up it to the IKE daemon.
>
> Signed-off-by: Olaf Kirch <okir@suse.de>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
Excellent catch, applied, thanks Olaf.
next prev parent reply other threads:[~2006-11-23 4:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-23 0:01 [PATCH] Make udp_encap_rcv use pskb_may_pull Olaf Kirch
2006-11-23 4:11 ` David Miller [this message]
2006-11-24 10:54 ` Ingo Oeser
2006-11-24 21:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061122.201136.129449260.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okir@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).