From: Dmitry Mishin <dim@openvz.org>
To: cramerj@intel.com
Cc: john.ronciak@intel.com, jesse.brandeburg@intel.com,
akpm@osdl.org, netdev@vger.kernel.org, devel@openvz.org,
xemul@openvz.org
Subject: [PATCH 2.6.18] e1000: fix initialization irqs
Date: Wed, 22 Nov 2006 15:49:14 +0300 [thread overview]
Message-ID: <200611221549.15765.dim@openvz.org> (raw)
In case of irqpoll boot option set, e1000 may oops due to:
1) e1000 register it's handler with e1000_request_irq
2) spurious interrupt happens
3) kernel tries to handle this interrupt with all available descs
4) e1000_intr is called and oops due to not initialized clean_rx handler,
because e1000_up is not called yet.
Solution is to initialize driver before handler registration.
Signed-off-by: Dmitry Mishin <dim@openvz.org>
Signed-off-by: Pavel Emelianov <xemul@openvz.org>
---
e1000_main.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
---
--- ./drivers/net/e1000/e1000_main.c.e1000 2006-09-20 07:42:06.000000000 +0400
+++ ./drivers/net/e1000/e1000_main.c 2006-11-22 14:08:15.000000000 +0300
@@ -1206,14 +1206,15 @@ e1000_open(struct net_device *netdev)
if ((err = e1000_setup_all_rx_resources(adapter)))
goto err_setup_rx;
- err = e1000_request_irq(adapter);
- if (err)
- goto err_up;
-
e1000_power_up_phy(adapter);
if ((err = e1000_up(adapter)))
goto err_up;
+
+ err = e1000_request_irq(adapter);
+ if (err)
+ goto err_up;
+
adapter->mng_vlan_id = E1000_MNG_VLAN_NONE;
if ((adapter->hw.mng_cookie.status &
E1000_MNG_DHCP_COOKIE_STATUS_VLAN_SUPPORT)) {
next reply other threads:[~2006-11-22 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 12:49 Dmitry Mishin [this message]
2006-11-22 16:19 ` [PATCH 2.6.18] e1000: fix initialization irqs Auke Kok
2006-11-22 16:43 ` Dmitry Mishin
2006-11-22 20:51 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611221549.15765.dim@openvz.org \
--to=dim@openvz.org \
--cc=akpm@osdl.org \
--cc=cramerj@intel.com \
--cc=devel@openvz.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).