netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: David Miller <davem@davemloft.net>
Cc: dgc@sgi.com, jesper.juhl@gmail.com, chatz@melbourne.sgi.com,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	xfs-masters@oss.sgi.com, netdev@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: 2.6.19-rc6 : Spontaneous reboots, stack overflows - seems to implicate xfs, scsi, networking, SMP
Date: Thu, 23 Nov 2006 18:08:37 +1100	[thread overview]
Message-ID: <20061123070837.GV11034@melbourne.sgi.com> (raw)
In-Reply-To: <20061122.201013.112290046.davem@davemloft.net>

On Wed, Nov 22, 2006 at 08:10:13PM -0800, David Miller wrote:
> From: David Chinner <dgc@sgi.com>
> Date: Thu, 23 Nov 2006 12:18:09 +1100
> 
> > So, assuming the stacks less than 32 bytes are 32 bytes, we've got
> > 1380 bytes in the XFS stack there, 
> 
> On sparc64 just the XFS parts of the backtrace would be a minimum of
> 2816 bytes (each function has a minimum 8 * 16 byte stack frame, and
> there are about 22 calls in that trace).

Ok, I didn't think of stack frames - I thought they tiny on x86 but
I'm not intimately familiar with x86 which is why I'm asking....

> It's probably a lot more
> with local variables and such.

Not much more than above - the same call path on ia64 and x86_64
using the stack checker addition method I used showed about a 35%
increase in stack usage compared to ia32. I'd say about 4.5k stack
usage on sparc64 for that call path, then.

FWIW, I've never heard of XFS related stack overflows on the
sparc64 platform - have you heard of any reports of this
being a problem?

> It's way too much.  You guys have to fix this stuff.

Sure, we're trying to but it takes time.  However, if it's such a
problem for you now and you want this process sped up, then _please,
please, please_ submit patches to help fix the problem.....

Realistically, XFS is only part of the problem here - the other part
of the problem is the amount of stack that softirqs are using (e.g.
the entire tcp send and receive path) which means we really have
much, much less than 4k of stack space to play with.

If the softirqs were run on a different stack, then a lot of these
problems would go away (29 of the 35 reported overflows had softirqs
running) and we'd be much more likely to get XFS to run reliably on
4k stacks...

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

  parent reply	other threads:[~2006-11-23  7:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-21  9:27 2.6.19-rc6 : Spontaneous reboots, stack overflows - seems to implicate xfs, scsi, networking, SMP Jesper Juhl
2006-11-21 21:53 ` David Chatterton
2006-11-21 22:02   ` Jesper Juhl
2006-11-21 23:31     ` David Chinner
2006-11-21 23:51       ` Jesper Juhl
2006-11-22 12:58         ` Jesper Juhl
2006-11-22 20:01           ` Stephen Hemminger
2006-11-23 10:27             ` Jesper Juhl
2006-11-23  1:18           ` David Chinner
2006-11-23  4:10             ` David Miller
2006-11-23  4:35               ` Al Viro
2006-11-23  6:47                 ` Matthew Wilcox
2006-11-23  8:12                 ` Arjan van de Ven
2006-11-23 22:08                   ` [xfs-masters] " Nathan Scott
2006-11-26 14:31                   ` Eric Sandeen
2006-11-23  7:08               ` David Chinner [this message]
2006-11-23 13:16                 ` Ingo Oeser
2006-11-23 18:37                   ` Arjan van de Ven
2006-11-23 19:54                     ` David Miller
2006-11-24  0:55                     ` David Chinner
2006-11-24  1:08                       ` Jesper Juhl
2006-11-24  2:05                         ` David Chinner
2006-11-24  7:52                       ` Arjan van de Ven
2006-11-23 19:42                 ` David Miller
2006-11-29  1:56             ` David Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061123070837.GV11034@melbourne.sgi.com \
    --to=dgc@sgi.com \
    --cc=chatz@melbourne.sgi.com \
    --cc=davem@davemloft.net \
    --cc=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=xfs-masters@oss.sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).