From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Mishin Subject: Re: [patch -mm] net namespace: empty framework Date: Thu, 23 Nov 2006 12:07:40 +0300 Message-ID: <200611231207.40634.dim@openvz.org> References: <4563007B.9010202@fr.ibm.com> <200611221955.56942.dim@openvz.org> <20061123023943.GA22931@sergelap.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Cedric Le Goater , Daniel Lezcano , Kirill Korotaev , Linux Kernel Mailing List , Andrew Morton , Herbert Poetzl , "Eric W. Biederman" , netdev@vger.kernel.org Return-path: Received: from mailhub.sw.ru ([195.214.233.200]:16535 "EHLO relay.sw.ru") by vger.kernel.org with ESMTP id S933343AbWKWJJr (ORCPT ); Thu, 23 Nov 2006 04:09:47 -0500 To: "Serge E. Hallyn" In-Reply-To: <20061123023943.GA22931@sergelap.austin.ibm.com> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thursday 23 November 2006 05:39, Serge E. Hallyn wrote: > Quoting Dmitry Mishin (dim@openvz.org): > > On Wednesday 22 November 2006 19:41, Serge E. Hallyn wrote: > > > Quoting Cedric Le Goater (clg@fr.ibm.com): > > > > Hello, > > > > > > > > Dmitry Mishin wrote: > > > > > This patch looks acceptable for us. > > > > > > > > good. shall we merge it then ? see comment below. > > > > > > > > > BTW, Daniel, we agreed to be based on the Andrey's patchset. I do > > > > > not see a reason, why Cedric force us to make some unnecessary work > > > > > and move existent patchset over his interface. > > > > > > > > yeah it's a bit different from andrey's but not that much and it's > > > > more in > > > > > > Where is Andrey's patch? > > > > This thread - http://thread.gmane.org/gmane.linux.network/42666 > > Thanks, Dmitry. Now I do recall seeing that before. > > That patchset appears to go part, but not all the way to fitting in with > the existing namespaces. For instance, you use exit_task_namespaces() for > refcounting, but don't put the net_namespace in the nsproxy and use your > own mechanism for unsharing. > > It really seems useful to have all the namespaces be consistent whenever > practical, and I don't think your patchset would need much tweaking to > fit onto Cedric's patch. Am I missing a complicating factor? No. I've already said, Cedric's patch is acceptable for us. -- Thanks, Dmitry.