* [6PACK] Masking bug in 6pack driver
@ 2006-11-23 18:30 Ralf Baechle
2006-11-23 19:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2006-11-23 18:30 UTC (permalink / raw)
To: netdev, David S. Miller, Jeff Garzik
Looks like a broken masking to me, binary not is used where bitwise not
was intended.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
drivers/net/hamradio/6pack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c
index 102c1f0..d1f6895 100644
--- a/drivers/net/hamradio/6pack.c
+++ b/drivers/net/hamradio/6pack.c
@@ -915,7 +915,7 @@ static void decode_prio_command(struct s
printk(KERN_DEBUG "6pack: protocol violation\n");
else
sp->status = 0;
- cmd &= !SIXP_RX_DCD_MASK;
+ cmd &= ~SIXP_RX_DCD_MASK;
}
sp->status = cmd & SIXP_PRIO_DATA_MASK;
} else { /* output watchdog char if idle */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [6PACK] Masking bug in 6pack driver
2006-11-23 18:30 [6PACK] Masking bug in 6pack driver Ralf Baechle
@ 2006-11-23 19:48 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-11-23 19:48 UTC (permalink / raw)
To: ralf; +Cc: netdev, jeff
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 23 Nov 2006 18:30:23 +0000
> Looks like a broken masking to me, binary not is used where bitwise not
> was intended.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Jeff, I've got this one.
Applied, thanks a lot!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-23 19:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-23 18:30 [6PACK] Masking bug in 6pack driver Ralf Baechle
2006-11-23 19:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).