From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: [NET_SCHED 04/06]: Fix endless loops (part 2): "simple" qdiscs Date: Fri, 24 Nov 2006 14:37:18 +0100 Message-ID: <20061124133718.GB1599@ff.dom.local> References: <20061124123350.GA1599@ff.dom.local> <4566EE7C.4090801@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: devik@cdi.cz, netdev@vger.kernel.org Return-path: Received: from mx10.go2.pl ([193.17.41.74]:54732 "EHLO poczta.o2.pl") by vger.kernel.org with ESMTP id S1757767AbWKXNaw (ORCPT ); Fri, 24 Nov 2006 08:30:52 -0500 To: Patrick McHardy Content-Disposition: inline In-Reply-To: <4566EE7C.4090801@trash.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Nov 24, 2006 at 02:07:08PM +0100, Patrick McHardy wrote: > Jarek Poplawski wrote: ... > > Probably it is as usual something with my eyes but > > it seems cbq needs in cbq_delete or cbq_destroy_class > > some treatment (about qdisc_destroy) similar to htb. > > No, you're right about this one, CBQ needs a few further fixes: > > - deactivating of active classes when grafting > > - purging of queue/q.qlen adjustment when deleting an active class > > - deactivating of active classes when q.qlen drops to zero in ->drop() > > - purging of queue and deactivating of active leaf classes > when attaching a new child (presuming CBQ can only carry > packets in leaf classes, I'm not sure about this) > > and something HTB should do is to turn intermediate classes > into leaves again when their last child is deleted. > > Are you interested in fixing this? :) Maybe someday I'll be capable enough! It looks complicated enough to have some fun. At present I don't even know how to use it... But I think, you are just in the subject, so it would be at least one point less for the future. Jarek P.