From: Thomas Graf <tgraf@suug.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: Adrian Bunk <bunk@stusta.de>,
netdev@vger.kernel.org, jamal <hadi@cyberus.ca>
Subject: Re: RFC: remove NET_CLS_POLICE?
Date: Mon, 27 Nov 2006 09:56:14 +0100 [thread overview]
Message-ID: <20061127085614.GT8693@postel.suug.ch> (raw)
In-Reply-To: <456994ED.9040405@trash.net>
* Patrick McHardy <kaber@trash.net> 2006-11-26 14:21
> One more thing NET_CLS_POLICE affects is CBQ reshape/reclassify
> handling, reshape_fail seems to be completely unhandled without
> NET_CLS_POLICE and reclassification looks like it behaves
> differently with tc actions. I'm not really sure what the
> reshape_fail stuff is used for, but it looks like we would loose
> a feature. Jamal?
Yes, this is the reason why it wasn't removed yet. It always
occured to me as a mystery why NET_ACT_POLICE didn't depend
on the same logic inside the qdiscs. That needs to be resolved
first. Also the compat code for the action variant to handle
old policer configurations is horrible and should be done in
a clear way.
next prev parent reply other threads:[~2006-11-27 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-26 6:29 RFC: remove NET_CLS_POLICE? Adrian Bunk
2006-11-26 13:21 ` Patrick McHardy
2006-11-27 8:56 ` Thomas Graf [this message]
2006-12-01 3:52 ` David Miller
2006-11-26 23:09 ` Andy Furniss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061127085614.GT8693@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=bunk@stusta.de \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).