netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Osterkamp <jens@de.ibm.com>
To: netdev@vger.kernel.org, cbe-oss-dev@ozlabs.org
Cc: jgarzik@pobox.com, jklewis@us.ibm.com
Subject: [RFC][PATCH] spidernet: enable fiber autonegotiation
Date: Mon, 27 Nov 2006 15:47:07 +0100	[thread overview]
Message-ID: <200611271547.07433.jens@de.ibm.com> (raw)


While experimenting with a copper passthrough module in bladecenter I found 
out that this needs autonegotiation enabled in order to work properly.
This quick hack enables it with the sideeffect of breaking other bladecenter 
switch configurations.
If anyone has any suggestions or has experimented with the same configuration, 
feel free to comment.

This patch is not meant for inclusion into mainline.

Signed-off-by: Jens Osterkamp <jens@de.ibm.com>

Index: linux-2.6.19-rc6/drivers/net/spider_net.c
===================================================================
--- linux-2.6.19-rc6.orig/drivers/net/spider_net.c
+++ linux-2.6.19-rc6/drivers/net/spider_net.c
@@ -1724,8 +1724,10 @@ spider_net_setup_phy(struct spider_net_c
  phy->mdio_read = spider_net_read_phy;
  phy->mdio_write = spider_net_write_phy;
 
+ /* reset phy, read id and setup phy struct with phy ops*/
  mii_phy_probe(phy, phy->mii_id);
 
+ /* write fix speed and duplex to BMCR */
  if (phy->def->ops->setup_forced)
   phy->def->ops->setup_forced(phy, SPEED_1000, DUPLEX_FULL);
 
Index: linux-2.6.19-rc6/drivers/net/sungem_phy.c
===================================================================
--- linux-2.6.19-rc6.orig/drivers/net/sungem_phy.c
+++ linux-2.6.19-rc6/drivers/net/sungem_phy.c
@@ -335,10 +335,6 @@ static int bcm5421_enable_fiber(struct m
  /* LEDs active in both modes, autosense prio = fiber */
  phy_write(phy, MII_NCONFIG, 0x945f);
 
- /* switch off fibre autoneg */
- phy_write(phy, MII_NCONFIG, 0xfc01);
- phy_write(phy, 0x0b, 0x0004);
-
  return 0;
 }
 
@@ -347,7 +343,7 @@ static int bcm5461_enable_fiber(struct m
  phy_write(phy, MII_NCONFIG, 0xfc0c);
  phy_write(phy, MII_BMCR, 0x4140);
  phy_write(phy, MII_NCONFIG, 0xfc0b);
- phy_write(phy, MII_BMCR, 0x0140);
+ phy_write(phy, MII_BMCR, 0x1140);
 
  return 0;
 }

             reply	other threads:[~2006-11-27 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-27 14:47 Jens Osterkamp [this message]
2006-11-27 15:05 ` [Cbe-oss-dev] [RFC][PATCH] spidernet: enable fiber autonegotiation Arnd Bergmann
2006-11-27 15:46   ` Jens Osterkamp
2006-11-27 16:05     ` Arnd Bergmann
     [not found] <OF866BFBF0.F4E98990-ON87257233.0069989E-86257233.006A0704@us.ibm.com>
2006-11-28  9:18 ` Jens Osterkamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611271547.07433.jens@de.ibm.com \
    --to=jens@de.ibm.com \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=jgarzik@pobox.com \
    --cc=jklewis@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).