Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

[Jeff Garzik]

Chris Stromsoe wrote:
> The in-kernel Chelsio cxgb driver in 2.6.19-rc5 is version 2.1.1 and 
> only supports the N110 and N210 10Gb ethernet boards.  The current 
> driver available from Chelsio[1] is 2.1.4a and supports the T110 and 
> T210 series boards, but is only available against 2.6.16.  Any chance of 
> an update to the in-kernel driver for 2.6.20 to support the T* series 
> cards?
> 
> -Chris
> 
> 1. http://service.chelsio.com/drivers/linux/n210/cxgb-2.1.4a.tar.gz

A bit of history:  this driver was merged in March 2005 (submitted by 
Chelsio), updated once in June 2005, and then the maintainers completely 
disappeared.

So, you get what you get...  if someone wants to dig through the updated 
cxgb driver and merge it with the kernel and test it... great.  But at 
this point it is abandonware.

	Jeff

[PATCH 1/2] chelsio: T200 support

[Stephen Hemminger]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

This patch is experimental, it applies after the earlier 6 chelsio cleanup
patches. Tested on a pair of T210 board's.

I took the chelsio's 2.2.0 version driver from:
	http://service.chelsio.com/drivers/linux/t210/cxgb2toe-2.2.0.tar.gz

Removed (from vendor code):
	- all TOE related code
	- support for 1G devices (later patch)
	- support for COUGAR chipset (since vendor code never built it)

Bug fixes (to vendor code):
	- fixed the transmit scheduler to not leak on removal
	- fixed the ESPI bug workaround to free skb's on close instead of
	  module removal, otherwise it gets stuck on module removal because the
	  skb's hold reference to device

De-vendorized:
	- remove /proc debug interface
	- got rid of OS dependent wrapper crap
	- removed code that was '#ifdef' for older kernel versions
	- changed the code/function layout back to original so that only the
	  differences remain  i.e s/chtoe/cxgb/
	- update vendor code from 2.6.16 to 2.6.19
	- get rid of sparse warnings
	- remove dead code

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

Patch is 68K (300K uncompressed) so please download from:
	
	http://developer.osdl.org/shemminger/prototypes/chelsio-t2.patch.gz

[-- Attachment #2: chelsio-t2.patch.gz --]
[-- Type: application/x-gzip, Size: 69636 bytes --]

[PATCH 2/2] chelsio: 1G board support

[Stephen Hemminger]

This patch is the addon to the Chelsio 10G driver to support their 1G boards.
I extracted this from the vendor driver version 2.2 code, and cleaned it up
to match the mainline code.

I don't have the hardware, so it probably doesn't work as is.  But getting
it to development kernel will get others to fix it.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

Patch is large 80K so please download from:
	http://developer.osdl.org/shemminger/prototypes/chelsio-1g.patch.gz

Re: [PATCH 1/2] chelsio: T200 support

[Francois Romieu]

Stephen Hemminger <shemminger@osdl.org> :
> This patch is experimental, it applies after the earlier 6 chelsio cleanup
> patches. Tested on a pair of T210 board's.

The whole serie is stored as branch 'chelsio' at:
git://electric-eye.fr.zoreil.com/home/romieu/linux/linux-2.6-out/.git chelsio

I have hand-edited a few patches to convert some spaces/tabs.

-- 
Ueimor

Re: [PATCH 1/2] chelsio: T200 support

[Andrew Morton]

On Tue, 28 Nov 2006 00:17:38 +0100
Francois Romieu <romieu@fr.zoreil.com> wrote:

> Stephen Hemminger <shemminger@osdl.org> :
> > This patch is experimental, it applies after the earlier 6 chelsio cleanup
> > patches. Tested on a pair of T210 board's.
> 
> The whole serie is stored as branch 'chelsio' at:
> git://electric-eye.fr.zoreil.com/home/romieu/linux/linux-2.6-out/.git chelsio

I think you meant
git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git#chelsio

> I have hand-edited a few patches to convert some spaces/tabs.

I'll try adding this to -mm.

I hope someone knows what's happening with this driver, because I've
seriously lost the plot.

Re: [PATCH 1/2] chelsio: T200 support

[Felix Marti]

Andrew:
> On Tue, 28 Nov 2006 00:17:38 +0100
> Francois Romieu <romieu@fr.zoreil.com> wrote:
>
> > Stephen Hemminger <shemminger@osdl.org> :
> > > This patch is experimental, it applies after the earlier 6 chelsio
cleanup
> > > patches. Tested on a pair of T210 board's.
> > 
> > The whole serie is stored as branch 'chelsio' at:
> >
git://electric-eye.fr.zoreil.com/home/romieu/linux/linux-2.6-out/.git
chelsio
>
> I think you meant
> git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git#chelsio
>
> > I have hand-edited a few patches to convert some spaces/tabs.
>
> I'll try adding this to -mm.
>
> I hope someone knows what's happening with this driver, because I've
> seriously lost the plot.

Most customers have been downloading the T2xx driver from our website in
order to take advantage of the TOE capability of the T2xx hardware.
However, there is value in updating the in-kernel driver (which supports
N110 and N210 only) to support the T2xx products in NIC mode. I will
test the patches this week and get back to the mailing list if there are
any issues.

Regards,
felix

Re: [PATCH 1/2] chelsio: T200 support

[Stephen Hemminger]

On Tue, 28 Nov 2006 10:03:31 -0800
"Felix Marti" <felix@chelsio.com> wrote:

> Andrew:
> > On Tue, 28 Nov 2006 00:17:38 +0100
> > Francois Romieu <romieu@fr.zoreil.com> wrote:
> >
> > > Stephen Hemminger <shemminger@osdl.org> :
> > > > This patch is experimental, it applies after the earlier 6 chelsio
> cleanup
> > > > patches. Tested on a pair of T210 board's.
> > > 
> > > The whole serie is stored as branch 'chelsio' at:
> > >
> git://electric-eye.fr.zoreil.com/home/romieu/linux/linux-2.6-out/.git
> chelsio
> >
> > I think you meant
> > git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git#chelsio
> >
> > > I have hand-edited a few patches to convert some spaces/tabs.
> >
> > I'll try adding this to -mm.
> >
> > I hope someone knows what's happening with this driver, because I've
> > seriously lost the plot.
> 
> Most customers have been downloading the T2xx driver from our website in
> order to take advantage of the TOE capability of the T2xx hardware.
> However, there is value in updating the in-kernel driver (which supports
> N110 and N210 only) to support the T2xx products in NIC mode. I will
> test the patches this week and get back to the mailing list if there are
> any issues.
> 

I am seeing lots of little bugs (like not using free_netdev), that would
have been caught if the current driver was in mainline.