From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [UDP(-Lite)]: consolidate v4 and v6 get|setsockopt code
Date: Mon, 27 Nov 2006 18:12:22 +0000 [thread overview]
Message-ID: <200611271812.23073@strip-the-willow> (raw)
In-Reply-To: <20061127.093134.45504470.davem@davemloft.net>
Quoting David Miller:
| > if (level == SOL_UDP || level == SOL_UDPLITE)
| > - return do_udpv6_setsockopt(sk, level, optname, optval, optlen);
| > + return udp_lib_setsockopt(sk, level, optname, optval, optlen,
| > + udp_v6_push_pending_frames );
| > return compat_ipv6_setsockopt(sk, level, optname, optval, optlen);
| > }
| > #endif
|
| Specifically, the space between the push_pending_frames final argument
| passed and the closing parenthesis was removed. Why did you put
| that there? It looks fugly :)
Thank you for ironing this out, and a nice euphemism, too |-) The intention was to match
the end of the arguments list in the preceding line. But it seems that my feeble attempts
to be neat here have not met with wide approval ..... still enjoying the euphemism :-)
Many thanks and best regards
Gerrit
prev parent reply other threads:[~2006-11-27 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-27 10:44 [PATCH] [UDP(-Lite)]: consolidate v4 and v6 get|setsockopt code Gerrit Renker
2006-11-27 17:31 ` David Miller
2006-11-27 18:12 ` Gerrit Renker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611271812.23073@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).