From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: kaber@trash.net, khc@pm.waw.pl, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org
Subject: Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function
Date: Tue, 28 Nov 2006 20:44:40 -0800 (PST) [thread overview]
Message-ID: <20061128.204440.39160464.davem@davemloft.net> (raw)
In-Reply-To: <E1GpHDJ-00059y-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 29 Nov 2006 15:38:29 +1100
> David Miller <davem@davemloft.net> wrote:
> >
> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > index 9264139..95e86ac 100644
> > --- a/include/linux/netdevice.h
> > +++ b/include/linux/netdevice.h
> > @@ -94,7 +94,9 @@ #endif
> > #endif
> >
> > #if !defined(CONFIG_NET_IPIP) && \
> > - !defined(CONFIG_IPV6) && !defined(CONFIG_IPV6_MODULE)
> > + !defined(CONFIG_NET_IPGRE) && \
> > + !defined(CONFIG_IPV6_SIT) && \
> > + !defined(CONFIG_IPV6_TUNNEL)
> > #define MAX_HEADER LL_MAX_HEADER
> > #else
> > #define MAX_HEADER (LL_MAX_HEADER + 48)
>
> What if ipip/gre are modules?
Good catch, I'll fix that up by adding the missing CONFIG_*_MODULE
cases.
Longer term this is really messy, we should handle this some
other way.
next prev parent reply other threads:[~2006-11-29 4:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 18:30 Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function Krzysztof Halasa
2006-11-28 19:58 ` Patrick McHardy
2006-11-28 20:48 ` Krzysztof Halasa
2006-11-28 21:45 ` Patrick McHardy
2006-11-28 23:56 ` Krzysztof Halasa
2006-11-29 2:28 ` Patrick McHardy
2006-11-29 4:25 ` David Miller
2006-11-29 4:38 ` Herbert Xu
2006-11-29 4:44 ` David Miller [this message]
2006-11-29 4:56 ` Herbert Xu
2006-11-29 5:04 ` David Miller
2006-11-29 6:51 ` Herbert Xu
2006-12-01 4:22 ` David Miller
2006-12-01 4:37 ` Herbert Xu
2006-12-12 1:33 ` David Miller
2006-11-29 7:35 ` Jarek Poplawski
2006-11-29 15:06 ` Krzysztof Halasa
2006-11-29 15:16 ` Krzysztof Halasa
2006-11-30 8:31 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128.204440.39160464.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).