From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: Broken commit: [NETFILTER]: ipt_REJECT: remove largely duplicate route_reverse function Date: Tue, 28 Nov 2006 21:04:16 -0800 (PST) Message-ID: <20061128.210416.59658806.davem@davemloft.net> References: <20061128.204440.39160464.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kaber@trash.net, khc@pm.waw.pl, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:50618 "EHLO sunset.davemloft.net") by vger.kernel.org with ESMTP id S933172AbWK2FER (ORCPT ); Wed, 29 Nov 2006 00:04:17 -0500 To: herbert@gondor.apana.org.au In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Herbert Xu Date: Wed, 29 Nov 2006 15:56:57 +1100 > David Miller wrote: > > > > Longer term this is really messy, we should handle this some > > other way. > > Definitely. I'm not sure whether 48 is enough even for recursive > tunnels. This should really just be a hint. It's OK to spend a > bit of time reallocating skb's if it's too small, but it's not OK > to die. The recursive tunnel case is handled by the PMTU reductions in the route, isn't it?