From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: a.p.zijlstra@chello.nl, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@elte.hu,
gandalf@wlug.westbo.se
Subject: Re: [PATCH] lockdep: fix sk->sk_callback_lock locking
Date: Wed, 29 Nov 2006 12:06:07 -0800 (PST) [thread overview]
Message-ID: <20061129.120607.21923563.davem@davemloft.net> (raw)
In-Reply-To: <20061129120709.GB22749@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 29 Nov 2006 23:07:09 +1100
> On Wed, Nov 29, 2006 at 12:42:24PM +0100, Peter Zijlstra wrote:
> >
> > However I'm not quite sure yet how to teach lockdep about this. The
> > proposed patch will shut it up though.
>
> As a rule I think we should never make semantic changes to shut up
> lockdep.
Especially ones which are costly, as this proposed change is in
that it disables software interrupts in a place where that
is completely unnecessary.
Let's not even consider this patch :)
prev parent reply other threads:[~2006-11-29 20:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1164547971.30244.22.camel@localhost.localdomain>
[not found] ` <1164635760.6588.27.camel@twins>
[not found] ` <1164660685.30244.36.camel@localhost.localdomain>
2006-11-28 12:07 ` [PATCH] lockdep: fix sk->sk_callback_lock locking Peter Zijlstra
2006-11-29 7:49 ` Herbert Xu
2006-11-29 8:44 ` Jarek Poplawski
2006-11-29 11:42 ` Peter Zijlstra
2006-11-29 12:07 ` Herbert Xu
2006-11-29 20:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061129.120607.21923563.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=gandalf@wlug.westbo.se \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).