From: Adrian Bunk <bunk@stusta.de>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org
Subject: Re: [SAA9730] Fix build error
Date: Wed, 29 Nov 2006 05:44:28 +0100 [thread overview]
Message-ID: <20061129044428.GF15364@stusta.de> (raw)
In-Reply-To: <20061128173259.GA19092@linux-mips.org>
On Tue, Nov 28, 2006 at 05:32:59PM +0000, Ralf Baechle wrote:
> Confusingly NET_PCI is also set for for non-PCI EISA configurations where
> building this driver will result in a build error due to a reference to
> pci_release_regions.
>
> While at it, remove the EXPERIMENTAL - in all its uglyness and despite
Please also remove the EXPERIMENTAL from the help text.
> the sincerest attempts of the buggy hardware the driver is known to work
> and limit the driver to the Atlas board - the only known system to ever
> use the SAA9730 before Phillips ended the short live of the SAA9730.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 4f22c8e..6b5b745 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -1762,7 +1762,7 @@ config VIA_RHINE_NAPI
>
> config LAN_SAA9730
> bool "Philips SAA9730 Ethernet support (EXPERIMENTAL)"
> - depends on NET_PCI && EXPERIMENTAL && MIPS
> + depends on NET_PCI && PCI && MIPS_ATLAS
> help
> The SAA9730 is a combined multimedia and peripheral controller used
> in thin clients, Internet access terminals, and diskless
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-11-29 4:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 17:32 [SAA9730] Fix build error Ralf Baechle
2006-11-29 4:44 ` Adrian Bunk [this message]
2006-11-29 17:10 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061129044428.GF15364@stusta.de \
--to=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).