From: David Miller <davem@davemloft.net>
To: kazunori@miyazawa.org
Cc: miika@iki.fi, Diego.Beltrami@hiit.fi,
herbert@gondor.apana.org.au, netdev@vger.kernel.org,
usagi-core@linux-ipv6.org
Subject: Re: [PATCH][IPSEC][6/7] inter address family ipsec tunnel
Date: Thu, 30 Nov 2006 17:05:03 -0800 (PST) [thread overview]
Message-ID: <20061130.170503.35356518.davem@davemloft.net> (raw)
In-Reply-To: <20061124143901.0db589b8.kazunori@miyazawa.org>
From: Kazunori MIYAZAWA <kazunori@miyazawa.org>
Date: Fri, 24 Nov 2006 14:39:01 +0900
> This patch fixes mtu calculation of IPv4
>
> ip_append_data should refer the mtu of "dst" not "path".
> if "dst" is stacked, "path" is the actual dst_entry in
> the routing table.
> therefore the mtu of "path" equals link mtu which is
> depends on the device so that it ignores the header length
> and the trailer length
> "dst" has mtu for creating packet.
>
> Signed-off-by: Miika Komu <miika@iki.fi>
> Signed-off-by: Diego Beltrami <Diego.Beltrami@hiit.fi>
> Signed-off-by: Kazunori Miyazawa <miyazawa@linux-ipv6.org>
I'm not sure about this change.
If you look at the code in this function, "mtu" is always used with
adjustments via 'exthdrlen' (which is set to rt->u.dst.header_len).
So it seems the encapsulation is taken into account.
Perhaps any problem you are seeing is some artifact of the ipv6 in
ipv4 tunnel implementation. Otherwise we'd have other reports of this
problem, wouldn't we?
next prev parent reply other threads:[~2006-12-01 1:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-24 5:39 [PATCH][IPSEC][6/7] inter address family ipsec tunnel Kazunori MIYAZAWA
2006-12-01 1:05 ` David Miller [this message]
2006-12-01 5:07 ` Kazunori MIYAZAWA
2006-12-04 1:58 ` David Miller
2006-12-04 2:28 ` David Miller
2006-12-04 2:50 ` Kazunori MIYAZAWA
2006-12-04 3:12 ` David Miller
2006-12-04 3:30 ` Herbert Xu
2006-12-04 4:26 ` (usagi-core 31727) " Kazunori MIYAZAWA
2006-12-04 6:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061130.170503.35356518.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Diego.Beltrami@hiit.fi \
--cc=herbert@gondor.apana.org.au \
--cc=kazunori@miyazawa.org \
--cc=miika@iki.fi \
--cc=netdev@vger.kernel.org \
--cc=usagi-core@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).