From: Stephen Hemminger <shemminger@osdl.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Don Fry <brazilnut@us.ibm.com>,
netdev@vger.kernel.org, amitkale@netxen.com, jeff@garzik.org,
netxenproj@linsyssoft.com, rob@netxen.com, sanjeev@netxen.com,
wendyx@us.ibm.com
Subject: Re: [PATCH 2/5] NetXen: temp monitoring, newer firmware support, mm footprint reduction
Date: Thu, 30 Nov 2006 19:13:11 -0800 [thread overview]
Message-ID: <20061130191311.4d9ba296@localhost.localdomain> (raw)
In-Reply-To: <20061201000204.GA19837@electric-eye.fr.zoreil.com>
> > @@ -869,7 +937,10 @@ static inline void netxen_nic_disable_in
> > /*
> > * ISR_INT_MASK: Can be read from window 0 or 1.
> > */
> > - writel(0x7ff, (void __iomem *)(adapter->ahw.pci_base + ISR_INT_MASK));
> > + writel(0x7ff,
> > + (void __iomem
> > + *)(PCI_OFFSET_SECOND_RANGE(adapter, ISR_INT_MASK)));
> > +
>
> Yuck
If pci_base were correctly typed __iomem the casting would not
be needed.
prev parent reply other threads:[~2006-12-01 3:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 18:50 [PATCH 2/5] NetXen: temp monitoring, newer firmware support, mm footprint reduction Don Fry
2006-12-01 0:02 ` Francois Romieu
2006-12-01 3:13 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061130191311.4d9ba296@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=amitkale@netxen.com \
--cc=brazilnut@us.ibm.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=netxenproj@linsyssoft.com \
--cc=rob@netxen.com \
--cc=romieu@fr.zoreil.com \
--cc=sanjeev@netxen.com \
--cc=wendyx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).