netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hadi@cyberus.ca
Cc: hidden@balabit.hu, netdev@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: RFC: XFRM changing the view of xfrm_aevent_id
Date: Fri, 01 Dec 2006 20:08:58 -0800 (PST)	[thread overview]
Message-ID: <20061201.200858.25157271.davem@davemloft.net> (raw)
In-Reply-To: <1164983872.3562.45.camel@localhost>

From: jamal <hadi@cyberus.ca>
Date: Fri, 01 Dec 2006 09:37:52 -0500

> The structure currently looks like
> 
> struct xfrm_aevent_id {
>         struct xfrm_usersa_id           sa_id;
>         __u32                           flags;
> };
> 
> I could add the two items mentioned above in it and break the ABI.
> This may sound dangerous, but the usage of this ABI is not widespread.
> AFAIK, the only other person who might have used this is Kristzian (on
> CC).
> 
> If this is considered evil, then i will transfer the two items in
> a new TLV but it wont be as pretty.
> 
> Thoughts?

Let's change it now while we still can.

A few months from now, I will probably not give the same
answer :)

  parent reply	other threads:[~2006-12-02  4:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-01 14:37 RFC: XFRM changing the view of xfrm_aevent_id jamal
2006-12-01 14:47 ` KOVACS Krisztian
2006-12-02  4:08 ` David Miller [this message]
2006-12-02 11:09   ` jamal
2006-12-03  6:22     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061201.200858.25157271.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=herbert@gondor.apana.org.au \
    --cc=hidden@balabit.hu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).