From: Ivo van Doorn <ivdoorn@gmail.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: "John W. Linville" <linville@tuxdriver.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 04/26] rt2x00: EEPROM 93Cx6
Date: Sun, 3 Dec 2006 19:45:58 +0100 [thread overview]
Message-ID: <200612031945.58543.IvDoorn@gmail.com> (raw)
In-Reply-To: <200612031339.28148.flamingice@sourmilk.net>
On Sunday 03 December 2006 19:39, Michael Wu wrote:
> On Sunday 03 December 2006 13:19, Ivo van Doorn wrote:
> > rt2400pci, rt2500pci and rt61pci share exactly the
> > same code for the eeprom reading. The only difference
> > is that rt61pci has a slightly different register reading
> > approach. In any case we have a lot of duplicate code.
> > Create a new module eeprom_93cx6 inside the rt2x00 folder
> > and make rt2x00 use that.
> Interesting. adm8211 has code to read 93C66 and 93C46 eeproms, and it looks
> similar, albeit smaller and simpler, to your 93cx6 reading code. However, it
> looks like your new eeprom reading code is general enough for adm8211 to use
> too. I'll have to try it..
Good to hear, I'll check it out as well.
If they are indeed similar the eeprom_93cx6 could be moved to a more general
location as well so the module can be shared. :)
Ivo
next prev parent reply other threads:[~2006-12-03 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-03 18:19 [PATCH 04/26] rt2x00: EEPROM 93Cx6 Ivo van Doorn
2006-12-03 18:39 ` Michael Wu
2006-12-03 18:45 ` Ivo van Doorn [this message]
2006-12-08 18:56 ` Ivo van Doorn
2006-12-09 2:00 ` Michael Wu
2006-12-09 13:05 ` Ivo Van Doorn
2006-12-13 15:44 ` Lennart Sorensen
2006-12-13 16:47 ` Ivo van Doorn
2006-12-13 17:05 ` Lennart Sorensen
2006-12-13 17:17 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612031945.58543.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=flamingice@sourmilk.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).