From: Stephen Hemminger <shemminger@osdl.org>
To: Andrew Victor <andrew@sanpeople.com>
Cc: netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 2
Date: Mon, 4 Dec 2006 10:01:24 -0800 [thread overview]
Message-ID: <20061204100124.619de892@freekitty> (raw)
In-Reply-To: <1165236128.4606.104.camel@fuzzie.sanpeople.com>
On 04 Dec 2006 14:42:08 +0200
Andrew Victor <andrew@sanpeople.com> wrote:
> This patch adds NetPoll / NetConsole support to the Atmel AT91RM9200
> Ethernet driver.
>
> Original patch from Bill Gatliff.
>
>
> Signed-off-by: Andrew Victor <andrew@sanpeople.com>
>
>
> diff -urN linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c linux-2.6.19-final/drivers/net/arm/at91_ether.c
> --- linux-2.6.19-final.orig/drivers/net/arm/at91_ether.c Mon Dec 4 14:27:21 2006
> +++ linux-2.6.19-final/drivers/net/arm/at91_ether.c Mon Dec 4 14:33:35 2006
> @@ -925,6 +925,17 @@
> return IRQ_HANDLED;
> }
>
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +static void at91ether_poll_controller(struct net_device *dev)
> +{
> + unsigned long flags;
> +
> + local_irq_save(flags);
> + at91ether_interrupt(dev->irq, dev, NULL);
> + local_irq_restore(flags);
> +}
> +#endif
poll_controller is always called with interrupts already disabled.
The third argument to interrupt routines was dropped (struct pt_regs) in 2.6.19.
Maybe that never got fixed in ARM?
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-12-04 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 12:42 [PATCH 2.6.19] AT91RM9200 Ethernet update 2 Andrew Victor
2006-12-04 18:01 ` Stephen Hemminger [this message]
2006-12-05 6:15 ` Andrew Victor
2006-12-04 23:42 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061204100124.619de892@freekitty \
--to=shemminger@osdl.org \
--cc=andrew@sanpeople.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).