From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference
Date: Mon, 4 Dec 2006 17:28:23 +0100 [thread overview]
Message-ID: <20061204162823.GQ8693@postel.suug.ch> (raw)
In-Reply-To: <1165249502.3643.9.camel@localhost>
* jamal <hadi@cyberus.ca> 2006-12-04 11:25
> On Mon, 2006-04-12 at 16:34 +0100, Patrick McHardy wrote:
> > Fix a regression from my nfmark mask patch for cls_fw.
> >
> > Thomas, Jamal, do you have an idea what this "old method" stuff
> > is used for? It seems it is only used during the below mentioned
> > race.
>
> AFAIK, that has been there forever. Alexey may know. I am not
> sure if removing it will break any scripts etc.
You mean the scripts get upset when the kernel oopses?
Very good spotting Patrick!
next prev parent reply other threads:[~2006-12-04 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 15:34 [NET_SCHED]: cls_fw: fix NULL pointer dereference Patrick McHardy
2006-12-04 16:25 ` jamal
2006-12-04 16:28 ` Thomas Graf [this message]
2006-12-04 16:39 ` Patrick McHardy
2006-12-04 16:59 ` Thomas Graf
2006-12-05 21:46 ` David Miller
2006-12-06 13:18 ` Jarek Poplawski
2006-12-06 17:17 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061204162823.GQ8693@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).