From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: [RFC][GENETLINK] move command capabilities to flags Date: Mon, 4 Dec 2006 17:31:15 +0100 Message-ID: <20061204163115.GR8693@postel.suug.ch> References: <1165060612.3564.8.camel@localhost> <20061204092041.GN8693@postel.suug.ch> <1165237269.3664.15.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, netdev@vger.kernel.org Return-path: Received: from postel.suug.ch ([194.88.212.233]:38086 "EHLO postel.suug.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937106AbWLDQay (ORCPT ); Mon, 4 Dec 2006 11:30:54 -0500 To: jamal Content-Disposition: inline In-Reply-To: <1165237269.3664.15.camel@localhost> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org * jamal 2006-12-04 08:01 > The savings bytes is one aspect; the other is the cleanliness. > transfering a boolean in that many bits is a little of overkill. > I think it is better to fix it now than later. > I know you mentioned libnl uses it. But that is something you can change > on your side. I dont know of any other app that uses it. Right but if some distro is based on exactly 2.6.19 the specific libnl parts won't work at all for a long time. > > If you > > really want to do it, remove the obsoleted attribute types, I don't > > like dead bodies laying around :-) > > I could resend the patch getting rid of those definitions. OK, I can live with it, I don't care for the breakage much.