netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/7] [IP] RULE: Add ifdef to FIB_RULE_INVERT since it is missing.
@ 2006-12-05 10:15 Masahide NAKAMURA
  2006-12-05 10:42 ` Thomas Graf
  0 siblings, 1 reply; 3+ messages in thread
From: Masahide NAKAMURA @ 2006-12-05 10:15 UTC (permalink / raw)
  To: shemminger; +Cc: netdev, Masahide NAKAMURA

Signed-off-by: Masahide NAKAMURA <nakam@linux-ipv6.org>
---
 ip/iprule.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/ip/iprule.c b/ip/iprule.c
index c584b18..1da64b8 100644
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -83,8 +83,10 @@ int print_rule(const struct sockaddr_nl 
 	else
 		fprintf(fp, "0:\t");
 
+#ifdef FIB_RULE_INVERT
 	if (r->rtm_flags & FIB_RULE_INVERT)
 		fprintf(fp, "not ");
+#endif
 
 	if (tb[RTA_SRC]) {
 		if (r->rtm_src_len != host_len) {
@@ -224,7 +226,9 @@ static int iprule_modify(int cmd, int ar
 
 	while (argc > 0) {
 		if (strcmp(*argv, "not") == 0) {
+#ifdef FIB_RULE_INVERT
 			req.r.rtm_flags |= FIB_RULE_INVERT;
+#endif
 		} else if (strcmp(*argv, "from") == 0) {
 			inet_prefix dst;
 			NEXT_ARG();
-- 
1.4.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/7] [IP] RULE: Add ifdef to FIB_RULE_INVERT since it is missing.
  2006-12-05 10:15 [PATCH 3/7] [IP] RULE: Add ifdef to FIB_RULE_INVERT since it is missing Masahide NAKAMURA
@ 2006-12-05 10:42 ` Thomas Graf
  2006-12-05 18:02   ` Stephen Hemminger
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Graf @ 2006-12-05 10:42 UTC (permalink / raw)
  To: Masahide NAKAMURA; +Cc: shemminger, netdev

* Masahide NAKAMURA <nakam@linux-ipv6.org> 2006-12-05 19:15
> Signed-off-by: Masahide NAKAMURA <nakam@linux-ipv6.org>
> ---
>  ip/iprule.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/ip/iprule.c b/ip/iprule.c
> index c584b18..1da64b8 100644
> --- a/ip/iprule.c
> +++ b/ip/iprule.c
> @@ -83,8 +83,10 @@ int print_rule(const struct sockaddr_nl 
>  	else
>  		fprintf(fp, "0:\t");
>  
> +#ifdef FIB_RULE_INVERT
>  	if (r->rtm_flags & FIB_RULE_INVERT)
>  		fprintf(fp, "not ");
> +#endif
>  
>  	if (tb[RTA_SRC]) {
>  		if (r->rtm_src_len != host_len) {
> @@ -224,7 +226,9 @@ static int iprule_modify(int cmd, int ar
>  
>  	while (argc > 0) {
>  		if (strcmp(*argv, "not") == 0) {
> +#ifdef FIB_RULE_INVERT
>  			req.r.rtm_flags |= FIB_RULE_INVERT;
> +#endif
>  		} else if (strcmp(*argv, "from") == 0) {
>  			inet_prefix dst;
>  			NEXT_ARG();

It's missing because you removed it.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/7] [IP] RULE: Add ifdef to FIB_RULE_INVERT since it is missing.
  2006-12-05 10:42 ` Thomas Graf
@ 2006-12-05 18:02   ` Stephen Hemminger
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2006-12-05 18:02 UTC (permalink / raw)
  To: Thomas Graf; +Cc: Masahide NAKAMURA, netdev

On Tue, 5 Dec 2006 11:42:31 +0100
Thomas Graf <tgraf@suug.ch> wrote:

> * Masahide NAKAMURA <nakam@linux-ipv6.org> 2006-12-05 19:15
> > Signed-off-by: Masahide NAKAMURA <nakam@linux-ipv6.org>
> > ---
> >  ip/iprule.c |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> > 
> > diff --git a/ip/iprule.c b/ip/iprule.c
> > index c584b18..1da64b8 100644
> > --- a/ip/iprule.c
> > +++ b/ip/iprule.c
> > @@ -83,8 +83,10 @@ int print_rule(const struct sockaddr_nl 
> >  	else
> >  		fprintf(fp, "0:\t");
> >  
> > +#ifdef FIB_RULE_INVERT
> >  	if (r->rtm_flags & FIB_RULE_INVERT)
> >  		fprintf(fp, "not ");
> > +#endif
> >  
> >  	if (tb[RTA_SRC]) {
> >  		if (r->rtm_src_len != host_len) {
> > @@ -224,7 +226,9 @@ static int iprule_modify(int cmd, int ar
> >  
> >  	while (argc > 0) {
> >  		if (strcmp(*argv, "not") == 0) {
> > +#ifdef FIB_RULE_INVERT
> >  			req.r.rtm_flags |= FIB_RULE_INVERT;
> > +#endif
> >  		} else if (strcmp(*argv, "from") == 0) {
> >  			inet_prefix dst;
> >  			NEXT_ARG();
> 
> It's missing because you removed it.

Not applied, FIB_RULE_INVERT stays

-- 
Stephen Hemminger <shemminger@osdl.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-12-05 18:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-05 10:15 [PATCH 3/7] [IP] RULE: Add ifdef to FIB_RULE_INVERT since it is missing Masahide NAKAMURA
2006-12-05 10:42 ` Thomas Graf
2006-12-05 18:02   ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).