netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rick.jones2@hp.com
Cc: shemminger@osdl.org, muli@il.ibm.com, jeff@garzik.org,
	amitkale@netxen.com, netdev@vger.kernel.org,
	brazilnut@us.ibm.com, netxenproj@linsyssoft.com, rob@netxen.com,
	romieu@fr.zoreil.com, sanjeev@netxen.com, wendyx@us.ibm.com
Subject: Re: network devices don't handle pci_dma_mapping_error()'s
Date: Wed, 06 Dec 2006 18:31:26 -0800 (PST)	[thread overview]
Message-ID: <20061206.183126.59673915.davem@davemloft.net> (raw)
In-Reply-To: <45777A0C.4010901@hp.com>

From: Rick Jones <rick.jones2@hp.com>
Date: Wed, 06 Dec 2006 18:18:52 -0800

> While tossing a TCP|UDP|SCTP|etc packet could be plusungood, especially 
> if the IOMMU fills frequently (for some suitable definiton of 
> frequently), is it really worth the effort to save say an ACK?

ACKs are less important than data packets sure.

But the drivers shouldn't be parsing packets at transmit time to
decide what to do.

And when this kind of thing fails, it's going to fail for all
the packets currently queued up to the device for transmit.
So it's likely not "just an ACK", but rather a set of several
packets composed of ACKs and data packets.

  reply	other threads:[~2006-12-07  2:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-01 13:40 [PATCH 2/3] NetXen: 64-bit memory fixes Amit S. Kale
2006-12-01 18:56 ` Stephen Hemminger
2006-12-02  5:32 ` Jeff Garzik
2006-12-04 18:39   ` network devices don't handle pci_dma_mapping_error()'s Stephen Hemminger
2006-12-05  7:00     ` Muli Ben-Yehuda
2006-12-06 18:16       ` Stephen Hemminger
2006-12-06 19:33         ` Muli Ben-Yehuda
2006-12-07  6:18           ` Amit S. Kale
2006-12-07 13:04             ` Muli Ben-Yehuda
2006-12-07  0:54         ` David Miller
2006-12-07  0:58           ` Stephen Hemminger
2006-12-07  1:13             ` David Miller
2006-12-07  2:18               ` Rick Jones
2006-12-07  2:31                 ` David Miller [this message]
2006-12-07  6:25             ` Amit S. Kale
2006-12-07  6:46               ` Stephen Hemminger
2006-12-07  6:55                 ` Amit S. Kale
2006-12-07  7:24               ` David Miller
2006-12-07 20:07                 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061206.183126.59673915.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amitkale@netxen.com \
    --cc=brazilnut@us.ibm.com \
    --cc=jeff@garzik.org \
    --cc=muli@il.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=netxenproj@linsyssoft.com \
    --cc=rick.jones2@hp.com \
    --cc=rob@netxen.com \
    --cc=romieu@fr.zoreil.com \
    --cc=sanjeev@netxen.com \
    --cc=shemminger@osdl.org \
    --cc=wendyx@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).