From: David Miller <davem@davemloft.net>
To: kazunori@miyazawa.org
Cc: miika@iki.fi, Diego.Beltrami@hiit.fi,
herbert@gondor.apana.org.au, netdev@vger.kernel.org,
usagi-core@linux-ipv6.org
Subject: Re: [PATCH][IPSEC][4/7] inter address family ipsec tunnel
Date: Wed, 06 Dec 2006 23:40:50 -0800 (PST) [thread overview]
Message-ID: <20061206.234050.77634656.davem@davemloft.net> (raw)
In-Reply-To: <20061206.233749.122048397.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 06 Dec 2006 23:37:49 -0800 (PST)
> From: Kazunori MIYAZAWA <kazunori@miyazawa.org>
> Date: Wed, 6 Dec 2006 20:35:37 +0900
>
> > Sorry, I mixed up changes in the patches. I described that [4/7] will add
> > "IPv6 over IPv4 IPsec tunnel". However I send a patch for "IPv4 over IPv6"
> > as a reply because it includes the discussing item.
> > So this patch adds IPv4 over IPv6 IPsec tunnel. It's complicated.
> >
> > I deleted subustituting NULL for rt->peer and moved atomic_inc stuff
> > under the "if" section.
>
> I have applied this patch, thanks for fixing it up.
Actually, I have to revert this change again, it still has a problem.
Sorry :-/
I very much feared the following kind of obstacle with these changes.
Specifically, references to modular IPV6 code from statically compiled
IPV4 code. Which produces the following build error:
net/built-in.o: In function `__xfrm4_bundle_create':xfrm4_policy.c:(.text+0x59a88): undefined reference to `xfrm6_output'
:xfrm4_policy.c:(.text+0x59ac0): undefined reference to `xfrm6_output'
Please test with IPV6 built modular in the future, thank you.
next prev parent reply other threads:[~2006-12-07 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-24 5:38 [PATCH][IPSEC][4/7] inter address family ipsec tunnel Kazunori MIYAZAWA
2006-12-01 0:48 ` David Miller
2006-12-01 4:41 ` Kazunori MIYAZAWA
2006-12-06 11:35 ` Kazunori MIYAZAWA
2006-12-07 7:37 ` David Miller
2006-12-07 7:40 ` David Miller [this message]
2006-12-07 7:48 ` David Miller
2006-12-07 11:23 ` Kazunori MIYAZAWA
2006-12-07 22:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061206.234050.77634656.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Diego.Beltrami@hiit.fi \
--cc=herbert@gondor.apana.org.au \
--cc=kazunori@miyazawa.org \
--cc=miika@iki.fi \
--cc=netdev@vger.kernel.org \
--cc=usagi-core@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).