From: Stephen Hemminger <shemminger@osdl.org>
To: Muli Ben-Yehuda <muli@il.ibm.com>
Cc: Jeff Garzik <jeff@garzik.org>,
"Amit S. Kale" <amitkale@netxen.com>,
netdev@vger.kernel.org, brazilnut@us.ibm.com,
netxenproj@linsyssoft.com, rob@netxen.com, romieu@fr.zoreil.com,
sanjeev@netxen.com, wendyx@us.ibm.com
Subject: Re: network devices don't handle pci_dma_mapping_error()'s
Date: Wed, 6 Dec 2006 10:16:44 -0800 [thread overview]
Message-ID: <20061206101644.27eeaf14@freekitty> (raw)
In-Reply-To: <20061205070045.GE3619@rhun.ibm.com>
On Tue, 5 Dec 2006 09:00:45 +0200
Muli Ben-Yehuda <muli@il.ibm.com> wrote:
> On Mon, Dec 04, 2006 at 10:39:49AM -0800, Stephen Hemminger wrote:
>
> > I notice that no current network driver handles dma mapping errors.
> > Might that be part of the problem. On i386, this never happens, and
> > it would be rare on most others.
>
> IOMMUs are already available on x86-64 and are going to get widespread
> with the the introduction of IOMMUs from Intel and AMD. Might as well
> fix it now...
>
> How about CONFIG_DEBUG_DMA_API that does book-keeping and yells if a
> driver is mis-using the DMA API?
>
> Cheers,
> Muli
I think it is really only an issue for drivers that turn on HIGH_DMA
and have limited mask values. The majority of drivers either only handle
32 bit (!HIGH_DMA) or do full 64 bit mapping. I don't know the details
of how we manage IOMMU, but doesn't mapping always work for those drivers.
That just leaves devices with odd size mask values that need to be
handle mapping errors.
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-12-06 18:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 13:40 [PATCH 2/3] NetXen: 64-bit memory fixes Amit S. Kale
2006-12-01 18:56 ` Stephen Hemminger
2006-12-02 5:32 ` Jeff Garzik
2006-12-04 18:39 ` network devices don't handle pci_dma_mapping_error()'s Stephen Hemminger
2006-12-05 7:00 ` Muli Ben-Yehuda
2006-12-06 18:16 ` Stephen Hemminger [this message]
2006-12-06 19:33 ` Muli Ben-Yehuda
2006-12-07 6:18 ` Amit S. Kale
2006-12-07 13:04 ` Muli Ben-Yehuda
2006-12-07 0:54 ` David Miller
2006-12-07 0:58 ` Stephen Hemminger
2006-12-07 1:13 ` David Miller
2006-12-07 2:18 ` Rick Jones
2006-12-07 2:31 ` David Miller
2006-12-07 6:25 ` Amit S. Kale
2006-12-07 6:46 ` Stephen Hemminger
2006-12-07 6:55 ` Amit S. Kale
2006-12-07 7:24 ` David Miller
2006-12-07 20:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061206101644.27eeaf14@freekitty \
--to=shemminger@osdl.org \
--cc=amitkale@netxen.com \
--cc=brazilnut@us.ibm.com \
--cc=jeff@garzik.org \
--cc=muli@il.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=netxenproj@linsyssoft.com \
--cc=rob@netxen.com \
--cc=romieu@fr.zoreil.com \
--cc=sanjeev@netxen.com \
--cc=wendyx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).