* [PATCH] irlan: fix header build warning
@ 2006-12-06 19:44 Randy Dunlap
2006-12-06 22:57 ` Samuel Ortiz
2006-12-07 0:57 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Randy Dunlap @ 2006-12-06 19:44 UTC (permalink / raw)
To: netdev; +Cc: samuel, davem
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix compile warning when CONFIG_PROC_FS=n:
include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared inside parameter list
include/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you want
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
include/net/irda/irlan_filter.h | 1 +
1 file changed, 1 insertion(+)
--- linux-2.6.19-git7.orig/include/net/irda/irlan_filter.h
+++ linux-2.6.19-git7/include/net/irda/irlan_filter.h
@@ -28,6 +28,7 @@
void irlan_check_command_param(struct irlan_cb *self, char *param,
char *value);
void irlan_filter_request(struct irlan_cb *self, struct sk_buff *skb);
+struct seq_file;
void irlan_print_filter(struct seq_file *seq, int filter_type);
#endif /* IRLAN_FILTER_H */
---
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irlan: fix header build warning
2006-12-06 19:44 [PATCH] irlan: fix header build warning Randy Dunlap
@ 2006-12-06 22:57 ` Samuel Ortiz
2006-12-07 0:57 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Samuel Ortiz @ 2006-12-06 22:57 UTC (permalink / raw)
To: Randy Dunlap; +Cc: netdev, davem
Hi Randy,
Thanks for the patch. Looks fine to me.
On Wed, Dec 06, 2006 at 11:44:07AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix compile warning when CONFIG_PROC_FS=n:
>
> include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared inside parameter list
> include/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you want
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Cheers,
Samuel.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irlan: fix header build warning
2006-12-06 19:44 [PATCH] irlan: fix header build warning Randy Dunlap
2006-12-06 22:57 ` Samuel Ortiz
@ 2006-12-07 0:57 ` David Miller
2006-12-07 1:08 ` Randy Dunlap
1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2006-12-07 0:57 UTC (permalink / raw)
To: randy.dunlap; +Cc: netdev, samuel
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, 6 Dec 2006 11:44:07 -0800
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix compile warning when CONFIG_PROC_FS=n:
>
> include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared inside parameter list
> include/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you want
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
How about we protect these function externs with CONFIG_PROC_FS ifdefs
instead?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irlan: fix header build warning
2006-12-07 0:57 ` David Miller
@ 2006-12-07 1:08 ` Randy Dunlap
2006-12-07 4:10 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2006-12-07 1:08 UTC (permalink / raw)
To: David Miller; +Cc: netdev, samuel
On Wed, 06 Dec 2006 16:57:17 -0800 (PST) David Miller wrote:
> How about we protect these function externs with CONFIG_PROC_FS ifdefs
> instead?
Sure.
---
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix compile warning when CONFIG_PROC_FS=n:
include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared inside parameter list
include/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you want
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
include/net/irda/irlan_filter.h | 2 ++
1 file changed, 2 insertions(+)
--- linux-2.6.19-git7.orig/include/net/irda/irlan_filter.h
+++ linux-2.6.19-git7/include/net/irda/irlan_filter.h
@@ -28,6 +28,8 @@
void irlan_check_command_param(struct irlan_cb *self, char *param,
char *value);
void irlan_filter_request(struct irlan_cb *self, struct sk_buff *skb);
+#ifdef CONFIG_PROC_FS
void irlan_print_filter(struct seq_file *seq, int filter_type);
+#endif
#endif /* IRLAN_FILTER_H */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irlan: fix header build warning
2006-12-07 1:08 ` Randy Dunlap
@ 2006-12-07 4:10 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2006-12-07 4:10 UTC (permalink / raw)
To: randy.dunlap; +Cc: netdev, samuel
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, 6 Dec 2006 17:08:18 -0800
> On Wed, 06 Dec 2006 16:57:17 -0800 (PST) David Miller wrote:
>
> > How about we protect these function externs with CONFIG_PROC_FS ifdefs
> > instead?
>
> Sure.
>
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix compile warning when CONFIG_PROC_FS=n:
>
> include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared inside parameter list
> include/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you want
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Looks great, applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-12-07 4:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-06 19:44 [PATCH] irlan: fix header build warning Randy Dunlap
2006-12-06 22:57 ` Samuel Ortiz
2006-12-07 0:57 ` David Miller
2006-12-07 1:08 ` Randy Dunlap
2006-12-07 4:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).