From: Stephen Hemminger <shemminger@osdl.org>
To: Andrew Victor <andrew@sanpeople.com>
Cc: netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH 2.6.19] AT91RM9200 Ethernet update 3
Date: Thu, 7 Dec 2006 09:19:57 -0800 [thread overview]
Message-ID: <20061207091957.390e68a3@freekitty> (raw)
In-Reply-To: <1165303792.12510.55.camel@fuzzie.sanpeople.com>
On 05 Dec 2006 09:29:52 +0200
Andrew Victor <andrew@sanpeople.com> wrote:
> hi Stephen,
>
> > Use netdev_alloc_skb instead. It sets skb->dev so you don't have to.
>
> netdev_alloc_skb() seems to cause 2 function calls [__netdev_alloc_skb()
> and __alloc_skb()], instead of just 1 for the dev_alloc_skb() case.
> It might be more efficient if the driver manually sets skb->dev.
That is trivial, and netdev_alloc_skb() is setup to handle other
issues in future.
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-12-07 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 12:50 [PATCH 2.6.19] AT91RM9200 Ethernet update 3 Andrew Victor
2006-12-04 18:08 ` Stephen Hemminger
2006-12-05 7:29 ` Andrew Victor
2006-12-07 17:19 ` Stephen Hemminger [this message]
2006-12-04 23:42 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061207091957.390e68a3@freekitty \
--to=shemminger@osdl.org \
--cc=andrew@sanpeople.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).