* [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie
@ 2006-12-10 17:27 Ulrich Kunitz
2006-12-10 17:39 ` Michael Buesch
2006-12-10 17:44 ` Johannes Berg
0 siblings, 2 replies; 4+ messages in thread
From: Ulrich Kunitz @ 2006-12-10 17:27 UTC (permalink / raw)
To: netdev; +Cc: John W. Linville, Andrew Morton, Johannes Berg, dsd
ieee80211softmac_wx_get_genie locks the associnfo mutex at
function exit. This patch fixes it. The patch is against Linus'
tree (commit af1713e0).
Signed-off-by: Ulrich Kunitz <kune@deine-taler.de>
---
net/ieee80211/softmac/ieee80211softmac_wx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c b/net/ieee80211/softmac/ieee80211softmac_wx.c
index 480d72c..fa2f7da 100644
--- a/net/ieee80211/softmac/ieee80211softmac_wx.c
+++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
@@ -463,7 +463,7 @@ ieee80211softmac_wx_get_genie(struct net
err = -E2BIG;
}
spin_unlock_irqrestore(&mac->lock, flags);
- mutex_lock(&mac->associnfo.mutex);
+ mutex_unlock(&mac->associnfo.mutex);
return err;
}
--
1.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie
2006-12-10 17:27 [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie Ulrich Kunitz
@ 2006-12-10 17:39 ` Michael Buesch
2006-12-10 17:44 ` Johannes Berg
1 sibling, 0 replies; 4+ messages in thread
From: Michael Buesch @ 2006-12-10 17:39 UTC (permalink / raw)
To: stable; +Cc: netdev, John W. Linville, Andrew Morton, Johannes Berg, dsd
This is
Signed-off-by: Michael Buesch <mb@bu3sch.de>
and also to be put into the -stable tree.
On Sunday 10 December 2006 18:27, Ulrich Kunitz wrote:
> ieee80211softmac_wx_get_genie locks the associnfo mutex at
> function exit. This patch fixes it. The patch is against Linus'
> tree (commit af1713e0).
>
> Signed-off-by: Ulrich Kunitz <kune@deine-taler.de>
> ---
> net/ieee80211/softmac/ieee80211softmac_wx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c b/net/ieee80211/softmac/ieee80211softmac_wx.c
> index 480d72c..fa2f7da 100644
> --- a/net/ieee80211/softmac/ieee80211softmac_wx.c
> +++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
> @@ -463,7 +463,7 @@ ieee80211softmac_wx_get_genie(struct net
> err = -E2BIG;
> }
> spin_unlock_irqrestore(&mac->lock, flags);
> - mutex_lock(&mac->associnfo.mutex);
> + mutex_unlock(&mac->associnfo.mutex);
>
> return err;
> }
--
Greetings Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie
2006-12-10 17:27 [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie Ulrich Kunitz
2006-12-10 17:39 ` Michael Buesch
@ 2006-12-10 17:44 ` Johannes Berg
2006-12-10 17:51 ` Michael Buesch
1 sibling, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2006-12-10 17:44 UTC (permalink / raw)
To: Ulrich Kunitz; +Cc: netdev, John W. Linville, Andrew Morton, dsd
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Sun, 2006-12-10 at 18:27 +0100, Ulrich Kunitz wrote:
> ieee80211softmac_wx_get_genie locks the associnfo mutex at
> function exit. This patch fixes it. The patch is against Linus'
> tree (commit af1713e0).
Looks good, I wonder how this slipped in.
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Ulrich Kunitz <kune@deine-taler.de>
> ---
> net/ieee80211/softmac/ieee80211softmac_wx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c b/net/ieee80211/softmac/ieee80211softmac_wx.c
> index 480d72c..fa2f7da 100644
> --- a/net/ieee80211/softmac/ieee80211softmac_wx.c
> +++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
> @@ -463,7 +463,7 @@ ieee80211softmac_wx_get_genie(struct net
> err = -E2BIG;
> }
> spin_unlock_irqrestore(&mac->lock, flags);
> - mutex_lock(&mac->associnfo.mutex);
> + mutex_unlock(&mac->associnfo.mutex);
>
> return err;
> }
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie
2006-12-10 17:44 ` Johannes Berg
@ 2006-12-10 17:51 ` Michael Buesch
0 siblings, 0 replies; 4+ messages in thread
From: Michael Buesch @ 2006-12-10 17:51 UTC (permalink / raw)
To: Johannes Berg; +Cc: Ulrich Kunitz, netdev, John W. Linville, Andrew Morton, dsd
On Sunday 10 December 2006 18:44, Johannes Berg wrote:
> On Sun, 2006-12-10 at 18:27 +0100, Ulrich Kunitz wrote:
> > ieee80211softmac_wx_get_genie locks the associnfo mutex at
> > function exit. This patch fixes it. The patch is against Linus'
> > tree (commit af1713e0).
>
> Looks good, I wonder how this slipped in.
Nobody calls this function, as it's rather useless. ;)
> Acked-by: Johannes Berg <johannes@sipsolutions.net>
>
> > Signed-off-by: Ulrich Kunitz <kune@deine-taler.de>
> > ---
> > net/ieee80211/softmac/ieee80211softmac_wx.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c b/net/ieee80211/softmac/ieee80211softmac_wx.c
> > index 480d72c..fa2f7da 100644
> > --- a/net/ieee80211/softmac/ieee80211softmac_wx.c
> > +++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
> > @@ -463,7 +463,7 @@ ieee80211softmac_wx_get_genie(struct net
> > err = -E2BIG;
> > }
> > spin_unlock_irqrestore(&mac->lock, flags);
> > - mutex_lock(&mac->associnfo.mutex);
> > + mutex_unlock(&mac->associnfo.mutex);
> >
> > return err;
> > }
>
--
Greetings Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-12-10 17:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-10 17:27 [PATCH] ieee80211softmac: Fix mutex_lock at exit of ieee80211_softmac_get_genie Ulrich Kunitz
2006-12-10 17:39 ` Michael Buesch
2006-12-10 17:44 ` Johannes Berg
2006-12-10 17:51 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).