From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Jeff Garzik <jeff@garzik.org>
Cc: David Miller <davem@davemloft.net>,
Ulrich Drepper <drepper@redhat.com>,
Andrew Morton <akpm@osdl.org>, netdev <netdev@vger.kernel.org>,
Zach Brown <zach.brown@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Chase Venters <chase.venters@clientec.com>,
Johann Borck <johann.borck@densedata.com>,
linux-kernel@vger.kernel.org
Subject: Re: [take26-resend1 0/8] kevent: Generic event handling mechanism.
Date: Tue, 12 Dec 2006 08:39:02 +0300 [thread overview]
Message-ID: <20061212053902.GC14420@2ka.mipt.ru> (raw)
In-Reply-To: <457D764E.9040308@garzik.org>
On Mon, Dec 11, 2006 at 10:16:30AM -0500, Jeff Garzik (jeff@garzik.org) wrote:
> Comments:
>
> * [oh, everybody will hate me for saying this, but...] to me, "kevent"
> implies an internal kernel subsystem. I would rather call it "uevent"
> or anything else lacking a 'k' prefix.
It is kernel subsystem indeed, which exports some of its part to
userspace.
I previously thought that prefix 'k' can only be confused with KDE.
> * I like the absolute timespec (and use of timespec itself)
And I do not, but I made them to make at least some progress.
> * more on naming: I think kevent_open would be more natural than
> kevent_init, since it opens a file descriptor.
It is also initializes ring buffer.
> * why is KEVENT_MAX not equal to KEVENT_POSIX_TIMER? (perhaps answer
> this question in a comment, if it is not a mistake)
I check for error number using '>=' and use it as array size,
so it is always bigger than the last entry id.
I will add a comment.
> * Kill all the CONFIG_KEVENT_xxx sub-options, or hide them under
> CONFIG_EMBEDDED. Application developers should NOT be left wondering
> whether or support for KEVENT_INODE was compiled into the kernel.
Ok, I will put them under !CONFIG_EMBEDDED.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2006-12-12 5:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2154985aa0591036@2ka.mipt.ru>
2006-12-11 14:50 ` [take26-resend1 0/8] kevent: Generic event handling mechanism Evgeniy Polyakov
2006-12-11 14:50 ` [take26-resend1 1/8] kevent: Description Evgeniy Polyakov
2006-12-11 14:50 ` [take26-resend1 2/8] kevent: Core files Evgeniy Polyakov
2006-12-11 14:50 ` [take26-resend1 3/8] kevent: poll/select() notifications Evgeniy Polyakov
2006-12-11 14:50 ` [take26-resend1 4/8] kevent: Socket notifications Evgeniy Polyakov
2006-12-11 14:50 ` [take26-resend1 5/8] kevent: Timer notifications Evgeniy Polyakov
2006-12-11 14:50 ` [take26-resend1 6/8] kevent: Pipe notifications Evgeniy Polyakov
2006-12-11 14:50 ` [take26-resend1 7/8] kevent: Signal notifications Evgeniy Polyakov
2006-12-11 14:50 ` [take26-resend1 8/8] kevent: Kevent posix timer notifications Evgeniy Polyakov
2006-12-11 16:32 ` [take26-resend1 7/8] kevent: Signal notifications Mauricio Lin
2006-12-12 5:45 ` Evgeniy Polyakov
2006-12-11 15:16 ` [take26-resend1 0/8] kevent: Generic event handling mechanism Jeff Garzik
2006-12-12 5:39 ` Evgeniy Polyakov [this message]
2006-12-12 13:39 ` Jeff Garzik
2006-12-12 7:03 ` [take27 " Evgeniy Polyakov
2006-12-12 7:03 ` [take27 1/8] kevent: Description Evgeniy Polyakov
2006-12-12 7:03 ` [take27 2/8] kevent: Core files Evgeniy Polyakov
2006-12-12 7:03 ` [take27 3/8] kevent: poll/select() notifications Evgeniy Polyakov
2006-12-12 7:03 ` [take27 4/8] kevent: Socket notifications Evgeniy Polyakov
2006-12-12 7:03 ` [take27 5/8] kevent: Timer notifications Evgeniy Polyakov
2006-12-12 7:03 ` [take27 6/8] kevent: Pipe notifications Evgeniy Polyakov
2006-12-12 7:03 ` [take27 7/8] kevent: Signal notifications Evgeniy Polyakov
2006-12-12 7:03 ` [take27 8/8] kevent: Kevent posix timer notifications Evgeniy Polyakov
2006-12-14 7:12 ` [take28 0/8] kevent: Generic event handling mechanism Evgeniy Polyakov
2006-12-14 7:12 ` [take28 1/8] kevent: Description Evgeniy Polyakov
2006-12-14 7:12 ` [take28 2/8] kevent: Core files Evgeniy Polyakov
2006-12-14 7:12 ` [take28 3/8] kevent: poll/select() notifications Evgeniy Polyakov
2006-12-14 7:12 ` [take28 4/8] kevent: Socket notifications Evgeniy Polyakov
2006-12-14 7:12 ` [take28 5/8] kevent: Timer notifications Evgeniy Polyakov
2006-12-14 7:12 ` [take28 6/8] kevent: Pipe notifications Evgeniy Polyakov
2006-12-14 7:12 ` [take28 7/8] kevent: Signal notifications Evgeniy Polyakov
2006-12-14 7:12 ` [take28 8/8] kevent: Kevent posix timer notifications Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061212053902.GC14420@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=akpm@osdl.org \
--cc=chase.venters@clientec.com \
--cc=davem@davemloft.net \
--cc=drepper@redhat.com \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=johann.borck@densedata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).