netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shemminger@osdl.org
Cc: bunk@stusta.de, tgraf@suug.ch, viro@ftp.linux.org.uk,
	jgarzik@pobox.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/net/loopback.c: convert to module_init()
Date: Wed, 13 Dec 2006 16:21:17 -0800 (PST)	[thread overview]
Message-ID: <20061213.162117.125896771.davem@davemloft.net> (raw)
In-Reply-To: <20061213154125.5e118ba5@dxpl.pdx.osdl.net>

From: Stephen Hemminger <shemminger@osdl.org>
Date: Wed, 13 Dec 2006 15:41:25 -0800

> But what if other network device is not a module. We want loopback
> to be first. so it needs to be before other device_initcall's

There is zero evidence that loopback must be first.

I was not able to provide any after my study of the code last night,
and I haven't seen any concrete proof shown today either.

You mentioned "the dst code" relies on ifindex==1, what exactly do you
mean by that?  Give specific code examples instead of ambiguous and
non-specific references.

And this claim doesn't make any sense, because anyone who looks at
drivers/net/Makefile can see that several drivers are linked in way
before Space.o, and thus when built statically would today end up in
the device list way before the loopback driver.  So it can't be
"broken" by Adrian's change, since it's already not putting loopback
first and we can prove this! :-)

  reply	other threads:[~2006-12-14  0:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-12 16:24 [2.6 patch] drivers/net/loopback.c: convert to module_init() Adrian Bunk
2006-12-13  1:17 ` David Miller
2006-12-13 13:40   ` Adrian Bunk
2006-12-13 13:54     ` Thomas Graf
2006-12-13 19:08   ` Stephen Hemminger
2006-12-13 19:36     ` Adrian Bunk
2006-12-13 20:12   ` Al Viro
2006-12-13 20:49     ` Thomas Graf
2006-12-13 23:01       ` Stephen Hemminger
2006-12-13 23:12         ` Adrian Bunk
2006-12-13 23:18           ` Thomas Graf
2006-12-13 23:31             ` Adrian Bunk
2006-12-13 23:41               ` Stephen Hemminger
2006-12-14  0:21                 ` David Miller [this message]
2006-12-14  0:23                 ` David Miller
2006-12-14  0:18             ` David Miller
2006-12-14  0:37     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061213.162117.125896771.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bunk@stusta.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    --cc=tgraf@suug.ch \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).