From: Al Viro <viro@ftp.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: bunk@stusta.de, jgarzik@pobox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/net/loopback.c: convert to module_init()
Date: Wed, 13 Dec 2006 20:12:14 +0000 [thread overview]
Message-ID: <20061213201213.GK4587@ftp.linux.org.uk> (raw)
In-Reply-To: <20061212.171756.85408589.davem@davemloft.net>
On Tue, Dec 12, 2006 at 05:17:56PM -0800, David Miller wrote:
> From: Adrian Bunk <bunk@stusta.de>
> Date: Tue, 12 Dec 2006 17:24:35 +0100
>
> > This patch converts drivers/net/loopback.c to using module_init().
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> I'm not %100 sure of this one, let's look at the comment you
> are deleting:
>
> > -/*
> > - * The loopback device is global so it can be directly referenced
> > - * by the network code. Also, it must be first on device list.
> > - */
> > -extern int loopback_init(void);
> > -
>
> in particular notice the part that says "it must be first on the
> device list".
>
> I'm not sure whether that is important any longer. It probably isn't,
> but we should verify it before applying such a patch.
There might be practical considerations along the lines of "we want
lookups for loopback to be fast"...
next prev parent reply other threads:[~2006-12-13 20:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 16:24 [2.6 patch] drivers/net/loopback.c: convert to module_init() Adrian Bunk
2006-12-13 1:17 ` David Miller
2006-12-13 13:40 ` Adrian Bunk
2006-12-13 13:54 ` Thomas Graf
2006-12-13 19:08 ` Stephen Hemminger
2006-12-13 19:36 ` Adrian Bunk
2006-12-13 20:12 ` Al Viro [this message]
2006-12-13 20:49 ` Thomas Graf
2006-12-13 23:01 ` Stephen Hemminger
2006-12-13 23:12 ` Adrian Bunk
2006-12-13 23:18 ` Thomas Graf
2006-12-13 23:31 ` Adrian Bunk
2006-12-13 23:41 ` Stephen Hemminger
2006-12-14 0:21 ` David Miller
2006-12-14 0:23 ` David Miller
2006-12-14 0:18 ` David Miller
2006-12-14 0:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213201213.GK4587@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).