From: Thomas Graf <tgraf@suug.ch>
To: Adrian Bunk <bunk@stusta.de>
Cc: Stephen Hemminger <shemminger@osdl.org>,
Al Viro <viro@ftp.linux.org.uk>,
David Miller <davem@davemloft.net>,
jgarzik@pobox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/net/loopback.c: convert to module_init()
Date: Thu, 14 Dec 2006 00:18:48 +0100 [thread overview]
Message-ID: <20061213231848.GY8693@postel.suug.ch> (raw)
In-Reply-To: <20061213231217.GB3629@stusta.de>
* Adrian Bunk <bunk@stusta.de> 2006-12-14 00:12
> On Wed, Dec 13, 2006 at 03:01:43PM -0800, Stephen Hemminger wrote:
> > Loopback should be there before protocols are started. It makes sense
> > to have a standard startup order.
>
> This actually becomes easier after my patch:
>
> Now that it's untangled from net_olddevs_init(), you can simply change
> the module_init(loopback_init) to a different initcall level.
Not really, the device management inits as subsys, the ip layer hooks
into fs_initcall() which comes right after. The loopback was actually
registered after the protocol so far. I think Adrian's patch is fine
if the module_init() is changed to device_initcall().
next prev parent reply other threads:[~2006-12-13 23:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 16:24 [2.6 patch] drivers/net/loopback.c: convert to module_init() Adrian Bunk
2006-12-13 1:17 ` David Miller
2006-12-13 13:40 ` Adrian Bunk
2006-12-13 13:54 ` Thomas Graf
2006-12-13 19:08 ` Stephen Hemminger
2006-12-13 19:36 ` Adrian Bunk
2006-12-13 20:12 ` Al Viro
2006-12-13 20:49 ` Thomas Graf
2006-12-13 23:01 ` Stephen Hemminger
2006-12-13 23:12 ` Adrian Bunk
2006-12-13 23:18 ` Thomas Graf [this message]
2006-12-13 23:31 ` Adrian Bunk
2006-12-13 23:41 ` Stephen Hemminger
2006-12-14 0:21 ` David Miller
2006-12-14 0:23 ` David Miller
2006-12-14 0:18 ` David Miller
2006-12-14 0:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213231848.GY8693@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).