From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: agospoda@redhat.com, netdev@vger.kernel.org, cjk@techma.com
Subject: Re: [PATCH 1/3][BNX2]: Fix panic in bnx2_tx_int().
Date: Thu, 14 Dec 2006 15:57:17 -0800 (PST) [thread overview]
Message-ID: <20061214.155717.94073310.davem@davemloft.net> (raw)
In-Reply-To: <1166063433.30522.5.camel@rh4>
From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 13 Dec 2006 18:30:33 -0800
> [BNX2]: Fix panic in bnx2_tx_int().
>
> There was an off-by-one bug in bnx2_tx_avail(). If the tx ring is
> completely full, the producer and consumer indices may be apart by
> 256 even though the ring size is only 255. One entry in the ring is
> unused and must be properly accounted for when calculating the number
> of available entries. The bug caused the tx ring entries to be
> reused by mistake, overwriting active entries, and ultimately causing
> it to crash.
>
> This bug rarely occurs because the tx ring is rarely completely full.
> We always stop when there is less than MAX_SKB_FRAGS entries available
> in the ring.
>
> Thanks to Corey Kovacs <cjk@techma.com> and Andy Gospodarek
> <agospoda@redhat.com> for reporting the problem and helping to collect
> debug information.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks.
prev parent reply other threads:[~2006-12-15 0:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 2:30 [PATCH 1/3][BNX2]: Fix panic in bnx2_tx_int() Michael Chan
2006-12-14 23:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061214.155717.94073310.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agospoda@redhat.com \
--cc=cjk@techma.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).